Hi,

The permission "Administer Twitter widget entities" is not working when given to some other roles except "Administrator". Other links like add (/admin/content/twitter_widget/add), edit (/admin/content/twitter_widget/2/edit) are working fine, When opens directly.

Example:-

Create test role give all the permission under "Twitter Profile Widget". And create user with test role and check following links :-

  • /admin/content/twitter_widget (not working)
  • /admin/content/twitter_widget/{widget_id}/edit (working)
  • /admin/content/twitter_widget/add (working)
  • /admin/content/twitter_widget/{widget_id}/delete (working)

Thanks

CommentFileSizeAuthor
#10 2017-07-18_1454.png59.26 KBprajaankit
#10 2017-07-18_1444.png18.04 KBprajaankit
#8 permission_issue-2893012-8.patch648 bytesBunty Badgujar
#6 Screen Shot 2017-07-17 at 10.13.57 AM.png80.72 KBmark_fullmer
#4 permission_administer_not_working-2893012-4.patch450 bytesmark_fullmer
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Bunty Badgujar created an issue. See original summary.

prajaankit’s picture

prajaankit CreditAttribution: prajaankit at ]init[ AG commented
Priority: Normal » Major
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
CreditAttribution: mark_fullmer as a volunteer and at University of Texas at Austin commented

Hi folks,

This should be fairly simple to resolve. I'll get it done this week.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
CreditAttribution: mark_fullmer as a volunteer and at University of Texas at Austin commented
Assigned: Unassigned » mark_fullmer
FileSize
permission_administer_not_working-2893012-4.patch450 bytes

The attached patch sets the route "/admin/config/media/twitter_profile_widget" to use the "Administer Twitter widget entities" permission.

Please note that for creation, revisioning, deletion, and viewing, there are separate permissions, as shown in the screenshot, that can be given to any roles.

  • mark_fullmer committed a1d0feb on 8.x-1.x 
    Issue #2893012 by mark_fullmer: Permission "Administer Twitter widget...
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
CreditAttribution: mark_fullmer as a volunteer and at University of Texas at Austin commented
FileSize
Screen Shot 2017-07-17 at 10.13.57 AM.png80.72 KB
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
CreditAttribution: mark_fullmer as a volunteer and at University of Texas at Austin commented
Version: 8.x-1.2 » 8.x-1.x-dev
Status: Active » Fixed
Bunty Badgujar’s picture

Bunty Badgujar CreditAttribution: Bunty Badgujar commented
Status: Fixed » Needs work
FileSize
permission_issue-2893012-8.patch648 bytes

Hi mark_fullmer,

Thanks for your quick reply. But your given patch is not solve this issue the because the routing you have added in patch is different then actual issue.

I have created new patch with the required routing, that will check the permission of this path "/admin/content/twitter_widget" for other role then the administrator.

Thanks

Bunty Badgujar’s picture

Bunty Badgujar CreditAttribution: Bunty Badgujar commented
Status: Needs work » Needs review
prajaankit’s picture

prajaankit CreditAttribution: prajaankit at ]init[ AG commented
FileSize
2017-07-18_1444.png18.04 KB
2017-07-18_1454.png59.26 KB

Hi Bunty ,

Thanks your updated patch ,

After apply your patch ,

/admin/content/twitter_widget (working) for Other roles than ADMIN also.

Thanks

prajaankit’s picture

prajaankit CreditAttribution: prajaankit at ]init[ AG commented

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
CreditAttribution: mark_fullmer as a volunteer and at University of Texas at Austin commented
Status: Needs review » Fixed

Thanks, folks. This has been committed & will be shortly packaged as a new release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.