[D8] Access by entity

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2892581

Project 2: https://www.drupal.org/node/2860527

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I have reviewed this module. Works great :)

Thanks

I tried this module on my local server and it works like a charm. No issues with the inherent working of the module.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectaccess_by_entitygit

I'm a robot and this is an automated message from Project Applications Scraper.

Please check PAReview having Drupal Coding Standards and Indentation Issues : https://pareview.sh/node/2237

FILE: /root/repos/pareviewsh/pareview_temp/access_by_entity.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
12 | ERROR | [x] There must be one blank line after the last USE
| | statement; 0 found;
16 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/src/AccessByEntityStorage.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
95 | ERROR | [ ] Doc comment short description must be on a single
| | line, further text should be a separate paragraph
98 | ERROR | [x] Parameter comment indentation must be 3 spaces, found
| | 4 spaces
100 | ERROR | [x] Parameter comment indentation must be 3 spaces, found
| | 4 spaces
102 | ERROR | [x] Parameter comment indentation must be 3 spaces, found
| | 4 spaces
104 | ERROR | [ ] Description for the @return value is missing
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/src/EntityTypeInfo.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
44 | ERROR | Parameter $access_by_entity_storage is not described in
| | comment
44 | ERROR | Parameter $entity_type_manager is not described in comment
44 | ERROR | Parameter $config is not described in comment
125 | ERROR | Parameter $entity is not described in comment
144 | ERROR | Parameter $route_name is not described in comment
155 | ERROR | Type hint "array" missing for $data
--------------------------------------------------------------------------

FILE: ...repos/pareviewsh/pareview_temp/tests/src/Unit/AccessByEntityTest.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/access_by_entity.routing.yml
-----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------
8 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.