Receiving this error when trying to access /admin/config if I have an LDAP server configured but my server does not have the PHP LDAP extension enabled:

Fatal error: Call to undefined function ldap_connect() in /vagrant/docroot/sites/all/modules/contrib/ldap/ldap_servers/LdapServer.class.php on line 274

We need to guard against this; shouldn't throw a fatal just due to the requirements check.

CommentFileSizeAuthor
#2 ldap-fatal_error_if_ldap_ext_missing-2892479-2.patch655 bytesazinck
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

azinck created an issue. See original summary.

azinck’s picture

azinck CreditAttribution: azinck commented
Status: Active » Needs review
FileSize
ldap-fatal_error_if_ldap_ext_missing-2892479-2.patch655 bytes
grahl’s picture

grahl
he/him
Location Zürich
CreditAttribution: grahl as a volunteer commented
Status: Needs review » Postponed

Hi

From my perspective there is a requirements check during installation for the extension and a runtime check as well. I worry that if we have some sites not failing hard but running in such an inconsistent state that we might receive additional issues with subtle bugs pertaining to it.

If this is something other people are unhappy with and report back that the patch works well, I'd consider adding it.

  • grahl committed 6ac0071 on 7.x-2.x authored by azinck 
    Issue #2892470 by azinck: Fatal error in LDAP Server if PHP LDAP...

  • grahl committed 66d047c on 8.x-3.x authored by azinck 
    Issue #2892470 by azinck: Fatal error in LDAP Server if PHP LDAP...
grahl’s picture

grahl
he/him
Location Zürich
CreditAttribution: grahl as a volunteer commented
Status: Postponed » Fixed

Thought about this some more and since it's more convenient, I'm adding it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.