thanks for your work on this module! the issue i've discovered is that using an image field chokes the module so that the site settings admin page can't be accessed to set the settings once all of the fields are created and configured. i've created, deleted and recreated image fields to see if it was a fluke, but i consistently get wsod with the error below when i visit /admin/content/site-settings. i've manually added the directory i'm setting as the field image directory, let the system create it and used the root files directory, same error. deleting the image field removes the issue (except we'd love to be able to use image fields!)

drupal 8.3.4, php 7.0.18

Error: Call to a member function getFileUri() on null in Drupal\site_settings\SiteSettingsRenderer->renderImage() (line 107 of /srv/bindings/badedd71b47a49b09a43eb02f67eb938/code/modules/site_settings/src/SiteSettingsRenderer.php) #0 /srv/bindings/badedd71b47a49b09a43eb02f67eb938/code/modules/site_settings/src/SiteSettingsRenderer.php(82): Drupal\site_settings\SiteSettingsRenderer->renderImage(Object(Drupal\file\Plugin\Field\FieldType\FileFieldItemList), 'image') #1 /srv/bindings/badedd71b47a49b09a43eb02f67eb938/code/modules/site_settings/src/SiteSettingEntityListBuilder.php(73): Drupal\site_settings\SiteSettingsRenderer->renderField(Object(Drupal\file\Plugin\Field\FieldType\FileFieldItemList)) #2 /srv/bindings/badedd71b47a49b09a43eb02f67eb938/code/modules/site_settings/src/SiteSettingEntityListBuilder.php(142): Drupal\site_settings\SiteSettingEntityListBuilder->buildRow(Object(Drupal\site_settings\Entity\SiteSettingEntity)) #3 /srv/bindings/badedd71b47a49b09a43eb02f67eb938/code/core/lib/Drupal/Core/Entity/Controller/EntityListController.php(22): Drupal\site_settings\SiteSettingEntityListBuilder->render() #4 [internal function]: Drupal\Core\Entity\Controller\EntityListController->listing('site_setting_en...') #5 /srv/bindings/badedd71b47a49b09a43eb02f67eb938/code/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array) #6 /srv/bindings/badedd71b47a49b09a43eb02f67eb938/code/core/lib/Drupal/Core/Render/Renderer.php(574): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #7 /srv/bindings/badedd71b47a49b09a43eb02f67eb938/code/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure)) #8 /srv/bindings/badedd71b47a49b09a43eb02f67eb938/code/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) #9 [internal function]: Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #10 /srv/bindings/badedd71b47a49b09a43eb02f67eb938/code/vendor/symfony/http-kernel/HttpKernel.php(144): call_user_func_array(Object(Closure), Array) #11 /srv/bindings/badedd71b47a49b09a43eb02f67eb938/code/vendor/symfony/http-kernel/HttpKernel.php(64): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1) #12 /srv/bindings/badedd71b47a49b09a43eb02f67eb938/code/core/lib/Drupal/Core/StackMiddleware/Session.php(57): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #13 /srv/bindings/badedd71b47a49b09a43eb02f67eb938/code/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #14 /srv/bindings/badedd71b47a49b09a43eb02f67eb938/code/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #15 /srv/bindings/badedd71b47a49b09a43eb02f67eb938/code/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(50): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #16 /srv/bindings/badedd71b47a49b09a43eb02f67eb938/code/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #17 /srv/bindings/badedd71b47a49b09a43eb02f67eb938/code/core/lib/Drupal/Core/DrupalKernel.php(656): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #18 /srv/bindings/badedd71b47a49b09a43eb02f67eb938/code/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request)) #19 {main}.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stuart_wagner created an issue. See original summary.

stuart_wagner’s picture

Priority: Major » Normal
stuart_wagner’s picture

update: after trying different combinations of settings, i was able to get the image field to behave as expected. the issue above kicks in if the alt and title fields are disabled. if they are not disabled (the default), the image field works fine and the module settings page can be reached.

scott_euser’s picture

Assigned: stuart_wagner » Unassigned

Hi stuart_wagner,
Interesting, the alt/title insight should help me reproduce and debug this. Will come back to you if more details are needed.
Thanks,
Scott

stuart_wagner’s picture

cool -- will happily test or help debug further. i had the issue kind of come and go, and toggling the alt/title fields seemed to help, but if i keep an image field enabled, i continue to intermittently get wsod at /admin/content/site-settings. of the other field types, i used link and text plain w/ no issues at all.

scott_euser’s picture

Status: Needs work » Needs review
FileSize
972 bytes

I've fixed this one on dev but in case you want to use it as a patch and stay on stable until next release, attached patch

scott_euser’s picture

Status: Needs review » Fixed
stuart_wagner’s picture

i dropped the patch in and will report back if there are issues, but seems to do the trick! thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.