Move Google Analytics analytics.js code from inline to be a file issue [#2891973]

Hello,

I followed the instructions for setting up advanced css/js aggregation as presented in the "ReadMe" file for the module. In addition to those settings, I selected 'move google analytics analytics.js code from inline to be a file issue'. I did this, in part, due to a PageSpeed Insight suggesting 'Leverage browser caching for the following cacheable resources: http://www.google-analytics.com/analytics.js (2 hours)' as a way to increase my page load speed. This change led to my site crashing with a 500 error. I am not sure if this is a bug or what but I am hoping someone can offer insights on how I can go about unchecking this selection from the back end or other ideas for restoring my website.

Thank you kindly in anticipation of your assistance.

Martin

Comment	File	Size	Author
#5	advagg-2891973-5-check-function-names.patch	1.36 KB	mikeytown2
#5	7.x-2.x: PHP 7 & MySQL 5.5, D7 6 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

3 July 2017 at 21:09

martinpsz created an issue. See original summary.

Comment #2

mikeytown2 CreditAttribution: mikeytown2 commented 3 July 2017 at 21:56

Any additional info on what the 500 error says?

Add this to your settings.php file to undo that setting

$conf['advagg_mod_ga_inline_to_file'] = FALSE;

Comment #3

martinpsz CreditAttribution: martinpsz commented 4 July 2017 at 01:33

Thank you Mikey...your advice helped solve the problem. It turns out that I did not have the Google Analytics module installed on this particular site. This, I theorize, might have caused Drupal to go haywire when it went looking for inline GA. I ended up turning off the Advanced Agg module after I brought my site back. Things are back to normal.

Comment #4

mikeytown2 CreditAttribution: mikeytown2 commented 4 July 2017 at 01:47

What version of the googleanalytics module are you using?

Comment #5

mikeytown2 CreditAttribution: mikeytown2 commented 4 July 2017 at 02:02

Status:

Active

» Needs review

File	Size
advagg-2891973-5-check-function-names.patch	1.36 KB
7.x-2.x: PHP 7 & MySQL 5.5, D7 6 pass

Comment #6

martinpsz CreditAttribution: martinpsz commented 5 July 2017 at 20:42

I did not have the Google Analytics model installed and enabled when I encountered this issue.

Comment #7

6 July 2017 at 23:57

mikeytown2 committed 007bfc4 on 7.x-2.x

Issue #2891973 by mikeytown2: Move Google Analytics analytics.js code...

Comment #8

mikeytown2 CreditAttribution: mikeytown2 commented 6 July 2017 at 23:57

Status:

Needs review

» Fixed

That's supper weird as module_exists should catch that. The committed patch will also use is_callable to make sure the 2 functions advagg wants to access inside of googleanalytics exist.