Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
https://www.drupal.org/docs/7/site-building-best-practices/best-practices
FILE: ...er/modules/job_scheduler_trigger/job_scheduler_trigger.admin.inc
----------------------------------------------------------------------
FOUND 17 ERRORS AFFECTING 16 LINES
----------------------------------------------------------------------
5 | ERROR | [x] Doc comment short description must end with a full
| | stop
6 | ERROR | [x] There must be exactly one blank line after the
| | file comment
7 | ERROR | [x] Missing function doc comment
53 | ERROR | [x] Expected 1 blank line after function; 2 found
57 | ERROR | [x] Doc comment short description must end with a full
| | stop
61 | ERROR | [x] A cast statement must be followed by a single
| | space
61 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken into
| | its own line
87 | ERROR | [x] Array indentation error, expected 4 spaces but
| | found 5
88 | ERROR | [x] Array indentation error, expected 4 spaces but
| | found 5
89 | ERROR | [x] Array indentation error, expected 4 spaces but
| | found 5
94 | ERROR | [x] Array indentation error, expected 6 spaces but
| | found 7
95 | ERROR | [x] Array indentation error, expected 6 spaces but
| | found 7
96 | ERROR | [x] Array indentation error, expected 6 spaces but
| | found 7
109 | ERROR | [x] Doc comment short description must end with a full
| | stop
121 | ERROR | [x] Doc comment short description must end with a full
| | stop
128 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
152 | ERROR | [x] Doc comment short description must end with a full
| | stop
----------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...heduler/modules/job_scheduler_trigger/job_scheduler_trigger.info
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
4 | ERROR | Drupal 7 core already requires PHP 5.2
----------------------------------------------------------------------
FILE: ...uler/modules/job_scheduler_trigger/job_scheduler_trigger.install
----------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 8 LINES
----------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
4 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz_bar().",, "* Implements hook_foo_BAR_ID_bar()
| | for xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or
| | "* Implements hook_foo_BAR_ID_bar() for block
| | templates."
10 | ERROR | [x] Array indentation error, expected 6 spaces but
| | found 7
11 | ERROR | [x] Array indentation error, expected 9 spaces but
| | found 8
12 | ERROR | [x] Array indentation error, expected 9 spaces but
| | found 8
13 | ERROR | [x] Array indentation error, expected 9 spaces but
| | found 8
14 | ERROR | [x] Array indentation error, expected 9 spaces but
| | found 8
15 | ERROR | [x] Array closing indentation error, expected 7
| | spaces but found 6
----------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...duler/modules/job_scheduler_trigger/job_scheduler_trigger.module
----------------------------------------------------------------------
FOUND 9 ERRORS AND 4 WARNINGS AFFECTING 13 LINES
----------------------------------------------------------------------
5 | ERROR | [x] Doc comment short description must start with a
| | capital letter
14 | WARNING | [ ] Line exceeds 80 characters; contains 83
| | characters
17 | ERROR | [x] Case breaking statements must be followed by a
| | single blank line
26 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.",
| | "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.tpl.php.", or "* Implements
| | hook_foo_BAR_ID_bar() for block templates."
56 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.",
| | "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.tpl.php.", or "* Implements
| | hook_foo_BAR_ID_bar() for block templates."
70 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.",
| | "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.tpl.php.", or "* Implements
| | hook_foo_BAR_ID_bar() for block templates."
75 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
88 | ERROR | [x] Doc comment short description must end with a
| | full stop
98 | ERROR | [x] Doc comment short description must end with a
| | full stop
101 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
112 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
113 | ERROR | [x] A cast statement must be followed by a single
| | space
119 | ERROR | [x] Doc comment short description must end with a
| | full stop
----------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Comment | File | Size | Author |
---|---|---|---|
#2 | fixed_best_practices-2891954-2.patch | 9.01 KB | renatog |
Comments
Comment #2
renatogComment #4
renatogFixed.
Commited in dev branch.
Regards.
Comment #5
renatog