Random fail in Drupal\Tests\locale\Functional\LocaleTranslationUiTest::testStringTranslation [#2891911]

How it looks

1) Drupal\Tests\locale\Functional\LocaleTranslationUiTest::testStringTranslation
Behat\Mink\Exception\ExpectationException: An option "en" exists in select "edit-langcode", but it should not.

Examples:
https://www.drupal.org/pift-ci-job/708332
https://www.drupal.org/pift-ci-job/571364
https://www.drupal.org/pift-ci-job/712560

Proposed resolution

Replace random name generation, because it gives value containing 'en' with 1/250 (rough frequency).
or
Implement more stringent verification criteria, because check full page on 'en' it is a bit naive.

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#20	interdiff-16-17-diff.txt	729 bytes	Anonymous (not verified)
#17	interdiff-16-17.txt	729 bytes	Anonymous (not verified)
#17	2891911-17.patch	741 bytes	Anonymous (not verified)
#17	8.4.x: PHP 5.6 & MySQL 5.5 22,115 pass PHP 7 & PostgreSQL 9.1 22,111 pass PHP 7 & SQLite 3.14 22,110 pass PHP 5.5 & MySQL 5.5 Patch Failed to Apply PHP 5.5 & PostgreSQL 9.1 Patch Failed to Apply PHP 5.5 & SQLite 3.8 Patch Failed to Apply
#16	interdiff-2-16.txt	720 bytes	Anonymous (not verified)
#16	2891911-16.patch	742 bytes	Anonymous (not verified)
#16	8.4.x: PHP 5.6 & MySQL 5.5 22,101 pass PHP 5.6 & PostgreSQL 9.1 22,111 pass PHP 5.6 & SQLite 3.8 22,110 pass
#2	2891911-2.patch	732 bytes	Anonymous (not verified)
#2	8.4.x: PHP 5.6 & MySQL 5.5 22,092 pass PHP 7 & PostgreSQL 9.1 22,089 pass, 3 fail PHP 7 & SQLite 3.14 22,088 pass, 3 fail
#2	2891911-2-test-only.patch	761 bytes	Anonymous (not verified)
#2	8.4.x: PHP 5.6 & MySQL 5.5 21,997 pass, 2 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Anonymous (not verified) CreditAttribution: Anonymous commented 3 July 2017 at 15:39

vaplas created an issue. See original summary.

Comment #2

Anonymous (not verified) CreditAttribution: Anonymous commented 3 July 2017 at 15:43

File	Size
2891911-2-test-only.patch	761 bytes
8.4.x: PHP 5.6 & MySQL 5.5 21,997 pass, 2 fail
2891911-2.patch	732 bytes
8.4.x: PHP 5.6 & MySQL 5.5 22,092 pass PHP 7 & PostgreSQL 9.1 22,089 pass, 3 fail PHP 7 & SQLite 3.14 22,088 pass, 3 fail

Comment #3

Anonymous (not verified) CreditAttribution: Anonymous commented 3 July 2017 at 15:44

Status:

Active

» Needs review

Comment #4

3 July 2017 at 16:41

The last submitted patch, 2: 2891911-2-test-only.patch, failed testing. View results

Comment #5

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 22 July 2017 at 20:27

Priority:	Normal	» Critical
Issue summary:	View changes

Marking critical since it's a random test failure.

Comment #6

Anonymous (not verified) CreditAttribution: Anonymous commented 22 July 2017 at 21:10

Issue summary:

View changes

Thank you, @xjm!

Comment #7

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 23 July 2017 at 09:19

Status:	Needs review	» Reviewed & tested by the community
Issue tags:		+Random test failure

#2 seems like a straightforward and correct fix to me. This issue is a classic case of a random string happening to match a different meaningful value, and simply providing a test value instead is better.

Thanks @vaplas!

Comment #8

27 July 2017 at 05:17

catch committed e242bbd on 8.4.x

Issue #2891911 by vaplas: Random fail in Drupal\Tests\locale\Functional\...

Comment #9

27 July 2017 at 05:17

catch committed 8384dc5 on 8.3.x

Issue #2891911 by vaplas: Random fail in Drupal\Tests\locale\Functional\...

Comment #10

catch

he/him

English

CreditAttribution: catch at Third and Grove commented 27 July 2017 at 05:17

Committed e242bbd and pushed to 8.4.x, then cherry-picked to 8.3.x. Thanks!

Comment #11

catch

he/him

English

CreditAttribution: catch at Third and Grove commented 27 July 2017 at 10:41

Status:

Reviewed & tested by the community

» Fixed

Comment #12

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan at PreviousNext commented 28 July 2017 at 04:03

Status:

Fixed

» Needs work

I think this broke HEAD on postgres and sqlite - its the only thing that went into 8.3 and 8.4 recently, and given its touching the same test - figure it was the culprit https://www.drupal.org/node/3060/qa

Comment #13

catch

he/him

English

CreditAttribution: catch at Third and Grove commented 28 July 2017 at 05:40

Status:

Needs work

» Needs review

Let's re-test on those databases.

Comment #14

28 July 2017 at 06:13

catch committed 9586b37 on 8.4.x

Revert "Issue #2891911 by vaplas: Random fail in Drupal\Tests\locale\...

Comment #15

28 July 2017 at 06:13

catch committed e5721b0 on 8.3.x

Revert "Issue #2891911 by vaplas: Random fail in Drupal\Tests\locale\...

Comment #16

Anonymous (not verified) CreditAttribution: Anonymous commented 28 July 2017 at 08:16

File	Size
2891911-16.patch	742 bytes
8.4.x: PHP 5.6 & MySQL 5.5 22,101 pass PHP 5.6 & PostgreSQL 9.1 22,111 pass PHP 5.6 & SQLite 3.8 22,110 pass
interdiff-2-16.txt	720 bytes

Good spot! Let's fix it.

Comment #17

Anonymous (not verified) CreditAttribution: Anonymous commented 28 July 2017 at 10:13

File	Size
2891911-17.patch	741 bytes
8.4.x: PHP 5.6 & MySQL 5.5 22,115 pass PHP 7 & PostgreSQL 9.1 22,111 pass PHP 7 & SQLite 3.14 22,110 pass PHP 5.5 & MySQL 5.5 Patch Failed to Apply PHP 5.5 & PostgreSQL 9.1 Patch Failed to Apply PHP 5.5 & SQLite 3.8 Patch Failed to Apply
interdiff-16-17.txt	729 bytes

4 files were hidden/shown/deleted

File	Size
2891911-2-test-only.patch	761 bytes
8.4.x: PHP 5.6 & MySQL 5.5 21,997 pass, 2 fail
2891911-2.patch	732 bytes
8.4.x: PHP 5.6 & MySQL 5.5 22,092 pass PHP 7 & PostgreSQL 9.1 22,089 pass, 3 fail PHP 7 & SQLite 3.14 22,088 pass, 3 fail
2891911-16.patch	742 bytes
8.4.x: PHP 5.6 & MySQL 5.5 22,101 pass PHP 5.6 & PostgreSQL 9.1 22,111 pass PHP 5.6 & SQLite 3.8 22,110 pass
interdiff-2-16.txt	720 bytes

с/c

Comment #18

catch

he/him

English

CreditAttribution: catch at Third and Grove commented 28 July 2017 at 12:34

This interdiff 16/17 doesn't match the patch in 17?

Comment #19

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 28 July 2017 at 12:41

+++ b/core/modules/locale/tests/src/Functional/LocaleTranslationUiTest.php
@@ -44,7 +44,7 @@ public function testStringTranslation() {
-    $name = 'name';
+    $name = 'сucurbitaceae';

Is this a botanical name? I don't recognize it. :)

Comment #20

Anonymous (not verified) CreditAttribution: Anonymous commented 28 July 2017 at 14:39

File	Size
interdiff-16-17-diff.txt	729 bytes

#18: Hah! This is really not my interdiff). The size of my interdiff (769 bytes), but content has more size (4196 bytes). And it looks like one of version here #2876670-35: D8: Add error reporting when download fails/messes up. Reupload interdiff (replace cyrillic character, it appeared when I converted the word to lowercase).

#19: Yep) I wanted to apply something that went beyond the datebase terms. In the original I wanted to say "бахчевые" (a family of melons and watermelons). But I missed a bit with the translation and got on the family of pumpkin, that is close too.

Comment #21

Anonymous (not verified) CreditAttribution: Anonymous commented 29 July 2017 at 01:02

#18: Steps to reproduce this bug:

Upload first file 'name.txt'. If file with such name already exists, then the current file will be renamed as 'name_0.txt'.
Click 'Remove' without send the file.
Upload second file with name 'name_0.txt'. View the contents of this file - it will be from the first file.

Comment #22

catch

he/him

English

CreditAttribution: catch at Third and Grove commented 29 July 2017 at 02:58

Status:

Needs review

» Reviewed & tested by the community

That sounds like a CDN or maybe varnish issue to me with #18.

Moving back to RTBC.

Comment #23

31 July 2017 at 04:45

catch committed 14c2920 on 8.5.x

Issue #2891911 by vaplas: Random fail in Drupal\Tests\locale\Functional\...

Comment #24

31 July 2017 at 04:45

catch committed f0f6935 on 8.4.x

Issue #2891911 by vaplas: Random fail in Drupal\Tests\locale\Functional\...

Comment #25

31 July 2017 at 04:46

catch committed 5f0dfad on 8.3.x

Issue #2891911 by vaplas: Random fail in Drupal\Tests\locale\Functional\...

Comment #26

catch

he/him

English

CreditAttribution: catch at Third and Grove commented 31 July 2017 at 04:46

Version:	8.4.x-dev	» 8.3.x-dev
Status:	Reviewed & tested by the community	» Fixed

Committed/pushed/cherry-picked to all three 8.x branches, thanks!

Comment #27

tacituseu CreditAttribution: tacituseu commented 31 July 2017 at 10:31

Not that I think it is the reason, but things started segfaulting after this commit:
https://www.drupal.org/pift-ci-job/728146
https://www.drupal.org/pift-ci-job/728160
https://www.drupal.org/pift-ci-job/728179
https://www.drupal.org/pift-ci-job/728206

Comment #28

14 August 2017 at 10:35

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Random fail in Drupal\Tests\locale\Functional\LocaleTranslationUiTest::testStringTranslation

How it looks

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

Related issues

Referenced by