Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I like your module. Here's a few suggestions to make it more usefull.
1. In the filebrowser_form, use a generic name for displaying the title instead of "hey" (ex. '#title' => t('Title'),
)
2. In theme_filebrowser_dir_listing :
2.1 Display the relative path instead of the full path for security reasons
2.2 Display no of files and dir. size after the files wich is more natural
// Concatenate them all together
$output .= '<p>' . t('Displaying %dir.', array('%dir' => $curr_dir)) . '</p>';
$output .= theme('table', $header, $rows, array('id' => 'filebrowser-file-listing'));
$output .= '<p>' . t('Contains @fc totaling @ds in size.', array('@fc' => format_plural(count($files), '1 file', '@count files'), '@ds' => format_size($total_size))) . '</p>';
3. I'm joining a complete french translation
Comments
Comment #1
Susurrus CreditAttribution: Susurrus commentedI agree with every issue here, and thanks for the French translation.
I like to be able to see at a glance how many files are in a folder and how big they are, which is why they're at the top. There was actually an older issue about this, which I agreed with, so it was moved to the top. As this happens in a theme function, you can override this as you like, so I'm not going to address that issue in the module. If, however, the theme function needs to be a little cleaner to facilitate this, that could and should definitely happen.
Comment #2
Susurrus CreditAttribution: Susurrus commentedAll are fixed following what I said in #1.
Comment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.