Support title attribute in iframes

Makes sense to me. Quick read of the patch looks ok. Mind you I don't know this module.

Two things:

Title cannot be last

Tested and regex only picks up the 'first' word if the title attribute is the last item in the row.
For example:
Fails:[video:test:1 align:center title:"Some Title Text"]
Only loads: "Some"
Passes: [video:test:1 title:"Some Title Text" align:center]
Loads: "Some Title Text"

Upgrading the Overall Module

Though useful, the patch would probably serve a better UI/UX (and be used more) to also update.

Meeting in ten, so I know the code is completely invalid (there is no hook_update or hook_form_alter, etc.), but you get the idea.

_video_filter_form could be changed with a new field:

  $form['video_filter']['title'] = array(
    '#type' => 'textfield',
    '#title' => t('Title'),
    '#maxlength' => 255,
    '#size' => 80,
    '#default_value' => '',
    '#weight' => 6,
  );

Then, within _video_filter_process, make a slight alteration:

      $video = array(
        'source' => $matches_code[2][$ci],
        'autoplay' => $filter->settings['video_filter_autoplay'],
        'related' => $filter->settings['video_filter_related'],
        'title' => $filter->settings['video_filter_title'],    <---- Right here?
      );

Though it might be a large endeavor, as it looks like the files within editors/ will each need adjustment to fix the editor forms.

Adding a tweak to Patch 6 (based on my comments from comment-7) which adds a data-entry field for the title attribute within each CKEditor.

Works in Chrome perfectly, but seems to fail on FireFox and Safari in placing the added code within the CKEditor field.

This could be an issue with CKEditor's caching though....

Didn't test the tweaks on either TinyMCE and/or fckeditor.

Next step seems like it would be prudent to revise the Codecs to retrieve and populate the title attribute for the user.

thanks for adding this, but.. patch is referenced from wrong location. It should be based from the module's directory, not from /modules

but even fixing this the patch fails in 3 places.. but this was with 7.x-3.4, possibly it is against 7.x-3.x

yes, it seems to apply to -dev; but doesn't work (no title is added from the shortcode).. also, -dev seems to be broken on its own.

As i couldn't get patch to work and mainly because my client didn't want to rely on editors filling in the title with the token, i created this small filter module which pulls the actual title from the video provider (only for YouTube and Vimeo, but likely works elsewhere) and adds as the iframe's title attr.

This works alongside (technically, "after") the video filter but will also work on any manually inserted video iframe (although not sure why someone would do that).

Thanks Peter.

Is this issue dead? This is causing accessibility issues on my site as well. @liquidcms's module looks cool, but alas, I'm using D8.

Thanks for the suggestion @mark_fullmer

Still wondering if a contributor can chime in to answer whether core will address this issue. Seems perfectly suitable for core functionality and shouldn't require a module (but good to know that there is one available if need be, though it does seem to be inactive).

This patch is based on the one in #8. I looked at that and manually applied the changes to the latest dev and then made fixes to make it work. Note that I only added the CKEditor parts since that's what I needed. The other editors' parts will need to be added and tested for this to be a total solution. But this is working for CKEditor, at least.

Might anyone be able to port Michelle's improvements to TinyMCE? Thanks.