Call-time pass-by-reference is deprecated since PHP 5.3 and prohibited since PHP 5.4 [#2890415]

The PHPCompatibility sniffer for PHPCS flags several issues related to "using call-time pass-by-reference"

$ phpcs --standard=PHPCompatibility --runtime-set testVersion 7.1 contrib/devel

===========================
CONTRIB (warnings excluded)
===========================
FILE: .../contrib/devel/webprofiler/src/Views/TraceableViewExecutable.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
138 | ERROR | Using a call-time pass-by-reference is deprecated
| | since PHP 5.3 and prohibited since PHP 5.4
----------------------------------------------------------------------

Comment	File	Size	Author
#3	devel-n2890415-3.patch	560 bytes	DamienMcKenna
#3	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.5 67 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

28 June 2017 at 16:34

click2tman created an issue. See original summary.

Comment #2

click2tman CreditAttribution: click2tman commented 28 June 2017 at 16:48

Version:	8.x-1.x-dev	» 8.x-1.0-rc2
Issue summary:	View changes

Comment #3

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 23 September 2017 at 19:25

Version:	8.x-1.0-rc2	» 8.x-1.x-dev
Status:	Active	» Needs review

File	Size
devel-n2890415-3.patch	560 bytes
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.5 67 pass

This is the code, but does it still work?

Comment #4

moshe weitzman CreditAttribution: moshe weitzman commented 2 October 2017 at 15:20

Anyone available to test this?

Comment #5

lussoluca

he/him

Italian

Italy

CreditAttribution: lussoluca at H2H Creative Productions commented 4 October 2017 at 20:04

Status:

Needs review

» Closed (works as designed)

I know that PHPCS is not happy with this, but the code for this method is copied from the Drupal\views\ViewExecutable.php from Core, with some minor modification.
I prefer not to change it to remain aligned with the Core version. Maybe we can open an issue on the Views issue queue (if it doesn't already exists)?

Comment #6

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 4 October 2017 at 21:08

Good catch, that file in Views still includes this line:

    // Let modules modify the view output after it is rendered.
    $module_handler->invokeAll('views_post_render', [$this, &$this->display_handler->output, $cache]);