Problem/Motivation

We need better handling of notification callbacks, as some callbacks are refused and without a proper error.

Proposed resolution

  1. Use locks properly on notification callback method
  2. Ensure we return a 503 code if something fails so the TMS retries

Remaining tasks

None.

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 2889783-notification-callbacks-2.patch15.52 KBpenyaskito
#2 2889783-notification-callbacks-2.only-tests.patch9.15 KBpenyaskito
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Active » Needs review
FileSize
2889783-notification-callbacks-2.only-tests.patch9.15 KB
2889783-notification-callbacks-2.patch15.52 KB

Attached patch with proposed resolution.

The last submitted patch, 2: 2889783-notification-callbacks-2.only-tests.patch, failed testing. View results

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Needs review » Reviewed & tested by the community

Tests passed and failed as expected.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Reviewed & tested by the community » Fixed

Committed 7e7f174 and pushed to 8.x-2.x. Thanks!

  • penyaskito committed 7e7f174 on 8.x-2.x 
    Issue #2889783 by penyaskito: Better handling of notification callbacks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.