FILE: ...oot/repos/pareviewsh/pareview_temp/src/Plugin/Block/DibaCarousel.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
--------------------------------------------------------------------------
103 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
105 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
230 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
247 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
277 | WARNING | NodeType::loadMultiple calls should be avoided in
| | classes, use dependency injection instead
306 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
339 | WARNING | Node::load calls should be avoided in classes, use
| | dependency injection instead
368 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
386 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
Comment | File | Size | Author |
---|---|---|---|
#6 | 2889692-6.patch | 1.87 KB | oriol_e9g |
#2 | diba_carousel-dependency-injection-2889692-2.patch | 6.7 KB | myLies |
Comments
Comment #2
myLies CreditAttribution: myLies as a volunteer and at Drupal Ukraine Community commentedI a little bit change plugin codebase for using dependency injection
please, take a look
Comment #3
myLies CreditAttribution: myLies as a volunteer and at Drupal Ukraine Community commentedComment #4
oriol_e9gCommited to dev branch! Thanks!
Comment #5
oriol_e9gMmmm, we still have one missing call
FILE: ...oot/repos/pareviewsh/pareview_temp/src/Plugin/Block/DibaCarousel.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
374 | WARNING | Node::load calls should be avoided in classes, use
| | dependency injection instead
Comment #6
oriol_e9gComment #7
oriol_e9gI have fixed all warings reported by Coder.