FILE: ...oot/repos/pareviewsh/pareview_temp/src/Plugin/Block/DibaCarousel.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
--------------------------------------------------------------------------
103 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
105 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
230 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
247 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
277 | WARNING | NodeType::loadMultiple calls should be avoided in
| | classes, use dependency injection instead
306 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
339 | WARNING | Node::load calls should be avoided in classes, use
| | dependency injection instead
368 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
386 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

oriol_e9g created an issue. See original summary.

myLies’s picture

I a little bit change plugin codebase for using dependency injection
please, take a look

myLies’s picture

Status: Needs work » Needs review
oriol_e9g’s picture

Status: Needs review » Fixed

Commited to dev branch! Thanks!

oriol_e9g’s picture

Mmmm, we still have one missing call

FILE: ...oot/repos/pareviewsh/pareview_temp/src/Plugin/Block/DibaCarousel.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
374 | WARNING | Node::load calls should be avoided in classes, use
| | dependency injection instead

oriol_e9g’s picture

Status: Fixed » Needs review
FileSize
1.87 KB
oriol_e9g’s picture

Status: Needs review » Fixed

I have fixed all warings reported by Coder.

  • oriol_e9g committed fba4921 on 8.x-1.x authored by myLies
    Issue #2889692 by myLies: Use dependency injection instead of \Drupal...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.