Problem/Motivation

/admin/modules contains the instruction:

Regularly review and install available updates to maintain a secure and current site.

This currently links to Available updates /admin/reports/updates, which provides a report but doesn't enable any action. Further, it reports on all modules, not just those requiring updates.

It might be better to instead link to /admin/modules/update, which not only specifically lists just those modules needing to be updated but also enables the action to do so.

Steps to reproduce

Proposed resolution

Change 'available updates' to link to /admin/reports/updates/

Remaining tasks

Update patch
Review

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#25 after-patch#22_2.png109.65 KBsonam.chaturvedi
#25 after-patch#22_1.png111.43 KBsonam.chaturvedi
#25 before-patch#22.png101 KBsonam.chaturvedi
#24 After--patch--pic.png62.85 KBvikashsoni
#24 Before--patch--pic.png64.33 KBvikashsoni
#23 afterpatch.png108.17 KBRinku Jacob 13
#23 beforepatch.png108.01 KBRinku Jacob 13
#22 updates-update.png138.43 KBvsujeetkumar
#22 module-update.png138.59 KBvsujeetkumar
#22 2889289-22.patch2.94 KBvsujeetkumar
#20 no-issue-existes.png218.53 KBvikashsoni
#12 Updates-Ok.png120.23 KBmahalingam_cs
#12 Issue-1.png125.11 KBmahalingam_cs
#9 change-available-updates-link-to-point-to-action-page-2889289.patch1.71 KBpramodga
#3 change-available-updates-link-to-point-to-action-page-2889289.patch1.69 KBpramodga
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Charles Belov created an issue. See original summary.

pramodga’s picture

pramodga CreditAttribution: pramodga at Cybage Software Pvt Ltd. for Cybage Software Pvt Ltd. commented
Assigned: Unassigned » pramodga
pramodga’s picture

pramodga CreditAttribution: pramodga at Cybage Software Pvt Ltd. for Cybage Software Pvt Ltd. commented
Status: Active » Needs review
FileSize
change-available-updates-link-to-point-to-action-page-2889289.patch1.69 KB

Done the changes as per suggestions. Please review.

pramodga’s picture

pramodga CreditAttribution: pramodga at Cybage Software Pvt Ltd. for Cybage Software Pvt Ltd. commented
Assigned: pramodga » Unassigned
jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented

Do we know why the patch did not get queued for testing when it was uploaded? The status was 'needs review' and the default is to test all patches. I have queued it now, and will do some manual testing too.

Status: Needs review » Needs work

The last submitted patch, 3: change-available-updates-link-to-point-to-action-page-2889289.patch, failed testing. View results

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented

Hi Pramodga,

The patch fails to apply because you created it within the 'core' folder - the first line is
a/modules/update/update.module. Patches for core code need to be created from the site root folder, so the first line of the patch should read a/core/modules/update/update.module

Jonathan

pramodga’s picture

pramodga CreditAttribution: pramodga at Cybage Software Pvt Ltd. for Cybage Software Pvt Ltd. commented

Thank You Jonathan for the comment. Will fix the issue and upload the updated patch.

pramodga’s picture

pramodga CreditAttribution: pramodga at Cybage Software Pvt Ltd. for Cybage Software Pvt Ltd. commented
FileSize
change-available-updates-link-to-point-to-action-page-2889289.patch1.71 KB

Please find the updated patch.

pramodga’s picture

pramodga CreditAttribution: pramodga at Cybage Software Pvt Ltd. for Cybage Software Pvt Ltd. commented
Status: Needs work » Needs review

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

mahalingam_cs’s picture

mahalingam_cs CreditAttribution: mahalingam_cs at TATA Consultancy Services commented
Status: Needs review » Needs work
FileSize
Issue-1.png125.11 KB
Updates-Ok.png120.23 KB

Patch from #9 was applied successfully , but the change is not reflecting for the link " available updates" which appears when the Update checker module is not enabled.

Screenshot attached.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

vikashsoni’s picture

vikashsoni CreditAttribution: vikashsoni as a volunteer and at Zyxware Technologies commented
FileSize
no-issue-existes.png218.53 KB

@Charles Belov
there is no issue exists i am getting proper update link this issue is resolved for reference sharing screenshot ....

Thanks @Charles Belov for updating me

Link has been updated reports to modules
for ref sharing screenshots....

Charles Belov’s picture

Charles Belov
he/him
Primary language English
Location San Francisco, CA, US
CreditAttribution: Charles Belov at San Francisco Municipal Transportation Agency commented

@vikashsoni I'm not sure what you believe the proper update link is. Your screen print shows the link going to /admin/reports/updates which is the link I reported as being problematic. I'm expecting it to go to /admin/modules/update instead.

/admin/reports/updates has a download link to the update but doesn't apply the link.

/admin/modules/update has a button that downloads the update and applies it.

vsujeetkumar’s picture

vsujeetkumar CreditAttribution: vsujeetkumar at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
2889289-22.patch2.94 KB
module-update.png138.59 KB
updates-update.png138.43 KB

@Charles Belov Re-roll patch for 9.3.x.

Also redirected the "Available Updates" link to the route "/admin/modules/update". And this link is present in the below message.

Regularly review and install 'available updates' to maintain a secure and current site.

And also redirected the "Available Updates" link to the route "/admin/reports/updates/update". And this link is present in the below message section.

There was a problem checking 'available updates' for Drupal.

Both "/admin/modules/update" & "/admin/reports/updates/update" links are redirected on the same page. For more information I have attached some screen shots, Please have a look and advise.

Rinku Jacob 13’s picture

Rinku Jacob 13 CreditAttribution: Rinku Jacob 13 at Zyxware Technologies commented
FileSize
beforepatch.png108.01 KB
afterpatch.png108.17 KB

Verified and tested Rerolled patch#22 on the drupal 9.3.x-dev version. Patch applied successfully and looks good to me.Adding screenshot for the reference.Need +1 RTBC

vikashsoni’s picture

vikashsoni CreditAttribution: vikashsoni as a volunteer and at Zyxware Technologies commented
FileSize
Before--patch--pic.png64.33 KB
After--patch--pic.png62.85 KB
sonam.chaturvedi’s picture

sonam.chaturvedi CreditAttribution: sonam.chaturvedi at QED42 for Drupal India Association commented
Status: Needs review » Reviewed & tested by the community
FileSize
before-patch#22.png101 KB
after-patch#22_1.png111.43 KB
after-patch#22_2.png109.65 KB

Verified and tested re-rolled patch#22.
Patch applied successfully on 9.3.x-dev.
+1 RTBC

Testing Steps:
1. Go to Admin > Extend
2. Check the "Available Updates" link in message "Regularly review and install 'available updates' to maintain a secure and current site." directs to the route "/admin/report/updates".
3. Now apply the patch
4. Verify the "Available Updates" link in message "Regularly review and install 'available updates' to maintain a secure and current site." directs to the route "/admin/modules/update"
5. Verify the "Available Updates" link in message "There was a problem checking 'available updates' for Drupal." directs to the route "/admin/report/updates/update"

Testing Results:
The "Available Updates" link in message "Regularly review and install 'available updates' to maintain a secure and current site." directs to the route "/admin/modules/update".

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs issue summary update, +Needs usability review

I applied the patch and went to /admin/modules. There are two links on the page with the text 'available updates' and they direct to two different pages. That is confusing. I think having a ux review would help to clarify what should be done, adding tag.

@Rinku Jacob 13, @ vikashsoni, thank you for looking into this issue. Screenshots were already posted and adding more add s noise and does not help advance the issue. Therefor, credit has been removed per How is credit granted for Drupal core issues.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Category: Feature request » Task
Issue summary: View changes
jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented

I have hidden the numerous screen shots from the list in the IS, as they caused the patch to not be shown. The patch is two years old, from 9.3 so I expect a re-roll will be required for 11.x.