Convert web tests to browser tests for content_translation module Part 2

Let's do it!)

+++ b/core/modules/content_translation/tests/src/Functional/ContentTranslationContextualLinksTest.php
@@ -118,60 +118,11 @@ public function testContentTranslationContextualLinks() {
-    // Check that the translate link appears on the node page.
...
-    $response = $this->renderContextualLinks(['node:node=1:'], 'node/' . $node->id());
-    $this->assertResponse(200);
-    $json = Json::decode($response);
-    $this->setRawContent($json['node:node=1:']);
-    $this->assertLinkByHref($translate_link, 0, 'The contextual link to translate the node is shown.');

+++ b/core/modules/content_translation/tests/src/FunctionalJavascript/ContentTranslationContextualLinksTest.php
@@ -0,0 +1,78 @@
+    // Check that the translate link appears on the node page.
+    $this->drupalLogin($this->translator);
+    $this->drupalGet('node/' . $node->id());
+    $translate_link = '/node/' . $node->id() . '/translations';
+    $links = $this->assertSession()->waitForElement('css', '[data-contextual-id^="node:node=1"] .contextual-links a[href^="' . $translate_link . '"]');
+    $this->assertNotNull($links);

Using a black box instead of parsing json response seems fair solution.

Thanks!
#6.2: Indeed! FunctionalJavascript/ContentTranslationContextualLinksTest.php is a new test and we don't need to copy the flaws from old test. Fixed.

Thank you, @xjm! Absolutely!

During the removal of the method, I was not at ease with my heart, because:

• it's someone's work that will disappear
• it turns out not quite equivalent converting
• child tests may be broken.

But the more I looked at this method, the greater the preponderance of the following arguments:

• it is an explicit rudiment of simpletest js-testing problems
• it tests the signs, not the real result (we do not need to know what format is returned, if only it worked)
• it is obsolete, because it indicates that this is:
  

  Copied from \Drupal\contextual\Tests\ContextualDynamicContextTest::renderContextualLinks().

  but this is not so long ago (from 11.09.2013, after #2074037: Add drupalPostUrl() — drupalPost()/drupalPostAjax() are for forms only, D8 JS performs non-form HTTP requests).

• if we keep it, we will also need to synchronize this test after changes in the algorithm of the rendering contextual linsk.
• if someone relies on this method, he can easily return it, but even better, if he goes to a more correct test.

In other words, a simple js-test that verifies the final result (black-box testing) seems much more efficient.

Thanks for understanding again! 🎉