Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #2870457: Convert web tests to browser tests for page_cache module
Scope:
Drupal\page_cache\Tests\PageCacheTest
Comment | File | Size | Author |
---|---|---|---|
#3 | 2887393-2.patch | 5.69 KB | naveenvalecha |
Comments
Comment #2
naveenvalechaUpdated Title
Comment #3
naveenvalechaThis patch will fail as a couple of helper methods assertNoCacheTag and others are missing in AssertPageCacheContextsAndTagsTrait which are required for this test.
Also,
BTB drupalGetHeader function is calling getResponseHeader of Mink Session class which internally changing the string to lowercase which making couple of tests fail.
How about overriding this method in BTB?
I'll continue it tomorrow.
//Naveen
Comment #6
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commentedI've added a patch to the parent issue.
It seems this issue can be closed in favor of https://www.drupal.org/node/2870457#comment-12296590. Check it out.
Comment #7
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commentedI think this issue doesn't make sense because all work is done here #2870457: Convert web tests to browser tests for page_cache module