Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.There were some issues with coding standards, like unnecessary string concat, 2 newlines at end of file, duplicated entry for "core" in info file and no blank line after the file comment.
I created a patch to fix all issues found on coder, I also attached the coder report.
Added another patch to revert unnecessary blank line after minified JS.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | advagg-2887356-8-coding_standards.patch | 336 bytes | mikeytown2 |
| |||
| #6 | coding_standards-2887356-6.patch | 380 bytes | Algarte |
| #6 | coder-advagg.txt | 1.06 KB | Algarte |
| #4 | coding_standards-2887356-3.patch | 6.88 KB | Algarte |
| #2 | coding_standards-2887356-2.patch | 7.89 KB | Algarte |
Comments
Comment #2
Algarte CreditAttribution: Algarte at CI&T commentedComment #4
Algarte CreditAttribution: Algarte at CI&T commentedComment #5
mikeytown2 CreditAttribution: mikeytown2 commentedString concat is for better readability. Core issue is because you checked via the dev download and not git; any patch you write will fail because of that.
Comment #6
Algarte CreditAttribution: Algarte at CI&T commentedThank you @mikeytown2 for clarifying those issues for me, after cloning the git version 7.x-2.x i managed to run coder again and had fewer issues.
Since I only removed the blank line after the file comment, there is no need to give any credits to me, my goal is to learn more about how to contribute to the community and also learn more about Drupal.
I attached two new files, the coder report and the new patch.
Comment #8
mikeytown2 CreditAttribution: mikeytown2 commentedThanks for the new patch! This is how the patch should look. Also https://pareview.sh/node/628 is pretty helpful for any d.o project.
Comment #10
mikeytown2 CreditAttribution: mikeytown2 commented