On the synchronisation screen, I'm getting notices like this:

Notice: Undefined index: user in Drupal\config_split\Config\SplitFilter->Drupal\config_split\Config\{closure}() (line 106 of modules/contrib/config_split/src/Config/SplitFilter.php). (repeat x 100 times or so in many variants)

(yes, I'm still using an older version of config split here, but the uksort function in the plugin file (http://cgit.drupalcode.org/config_split/tree/src/Plugin/ConfigFilter/Spl...) hasn't really changed compared to the older version, so not sure exactly what's going on here.

It causes the order of the modules to be different on the sync screen, which isn't ideal :)

This works fine though on php 5.6.20

CommentFileSizeAuthor
#7 2887253-6.patch1.08 KBswentel
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

swentel created an issue. See original summary.

swentel’s picture

Issue summary: View changes
bircher’s picture

Hi,

Thanks for reporting the bug. Could you change the version of this issue to reflect the version you are using?
The way $modules is assigned and subsequently $data['module'] = array_merge($data['module'], $modules); changed due to notices and bugs in some situations. (when splits were deleted or not exported etc).
That would help me debug it and find out if it is still relevant, and if so solve it.

Also if you are on beta2 or before I suggest you update now as there is just documentation left before the stable release and it will have the crutch for enabling config_filter removed, so you would have to update to beta6 for example first or wait for #2863986: Allow updating modules with new service dependencies.

swentel’s picture

Version: 8.x-1.x-dev » 8.x-1.0-beta1

Still on beta 1 :)

swentel’s picture

Version: 8.x-1.0-beta1 » 8.x-1.0-beta6

Note, this is still on Drupal 8.2.6, so maybe that's the culprit and I should upgrade to 8.3.x (I know, should do that anyway)

But getting this on beta6 now too, here's the backtrace

Notice: Undefined index: user in Drupal\config_split\Plugin\ConfigFilter\SplitFilter->Drupal\config_split\Plugin\ConfigFilter\{closure}() (line 148 of modules/contrib/config_split/src/Plugin/ConfigFilter/SplitFilter.php).
Drupal\config_split\Plugin\ConfigFilter\SplitFilter->Drupal\config_split\Plugin\ConfigFilter\{closure}('user', 'score_resource')
uksort(Array, Object) (Line: 153)
Drupal\config_split\Plugin\ConfigFilter\SplitFilter->filterRead('core.extension', Array) (Line: 244)
Drupal\config_split\Plugin\ConfigFilter\SplitFilter->filterReadMultiple(Array, Array) (Line: 81)
Drupal\config_filter\Config\FilteredStorage->readMultiple(Array) (Line: 95)
Drupal\Core\Config\CachedStorage->readMultiple(Array) (Line: 409)
Drupal\Core\Config\StorageComparer->getAndSortConfigData('') (Line: 204)
Drupal\Core\Config\StorageComparer->createChangelist() (Line: 181)
Drupal\config\Form\ConfigSync->buildForm(Array, Object)
call_user_func_array(Array, Array) (Line: 514)
Drupal\Core\Form\FormBuilder->retrieveForm('config_admin_import_form', Object) (Line: 271)
Drupal\Core\Form\FormBuilder->buildForm('config_admin_import_form', Object) (Line: 74)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 574)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
call_user_func_array(Object, Array) (Line: 144)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 64)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 50)
Drupal\musescore_ip\BanMiddleware->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 652)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
swentel’s picture

So it's not related to Drupal core, I have another installation on core 8.3.x and latest config_filter and split and getting the same notices .. trying to debug now

swentel’s picture

Status: Active » Needs review
FileSize
1.08 KB

It seems to be reference thing, attached patch fixes it.

swentel’s picture

Changing credits

  • bircher committed f2db2ae on 8.x-1.x
    Issue #2887253 by swentel: Fix notices on php 7
    
bircher’s picture

Version: 8.x-1.0-beta6 » 8.x-1.x-dev
Status: Needs review » Fixed

Thanks for the contribution!

You are right it is not a drupal core issue so long as the schema stays the same. (which it still is in 8.4)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.