[Ubercart] Migrate post_checkout order status

It seems I left the IS half finished. This is really about what to do for the 'post_checkout' status.

Been a while since I looked at this, so starting at the beginning.

The test db has the following order_status_ids and states:

MariaDB [cm_dump]> select * from uc_order_statuses;
+-------------------+------------------+------------------+--------+--------+
| order_status_id   | title            | state            | weight | locked |
+-------------------+------------------+------------------+--------+--------+
| canceled          | Canceled         | canceled         |    -20 |      1 |
| completed         | Completed        | completed        |     20 |      1 |
| in_checkout       | In checkout      | in_checkout      |    -10 |      1 |
| payment_received  | Payment received | payment_received |     10 |      1 |
| pending           | Pending          | post_checkout    |      0 |      1 |
| processing        | Processing       | post_checkout    |      5 |      1 |
| testing           | Testing          | post_checkout    |      0 |      0 |
| testing-completed | Testing          | completed        |      0 |      0 |

The current process for the state is:

  state:
    plugin: static_map
    source: order_status
    default_value: draft
    map:
      # These are the equivalent order states I was able to gather from the
      # documentation.
      in_checkout: draft
      pending: validation
      payment_received: completed
      completed: completed
      canceled: canceled

From this it is clear that the static_map is using the order_status_id as the source information and ignoring the value of the state.

Then there is the order table which uses the order_status_id. The state values as given in the first table, uc_order_status, do not appear in any field of the order table. Again, it seems that only the order_status_id is to be migrated.

MariaDB [cm_dump]> select order_id,order_status from uc_orders;
+----------+------------------+
| order_id | order_status     |
+----------+------------------+
|        3 | completed        |
|        2 | payment_received |
|        1 | pending          |
|        4 | processing       |
+----------+------------------+
4 rows in set (0.13 sec)

However, uc_order_statuses has 6 non testing status ids and the static map only has 5. The value 'processing' is ignored. But the process has a default value of 'draft'. Therefore a Ubercart order_status_id of 'processing' will be converted to 'draft'. That seems reasonable. Is that correct?

If it is, or it should be a different value, it would be better to have it explicit in the map and remove any confusion about why it is being treated differently than the other order_status_ids.

So a simple one line fix to make it explicit that 'processing' is migrated to 'draft'.

There is an existing test for an order with an order_status_id of 'processing' that is converted to 'draft'. It is order_id 4, see here http://cgit.drupalcode.org/commerce_migrate/tree/modules/ubercart/tests/...

So this wee fix is good to go.

Update the IS