uc_order_condition_total() checks $order->total.
uc_order_condition_subtotal() checks line item 'subtotal'.
But these 2 values may not be calculated yet at the time conditions are evaluated.
Conditions should calculate these values themselves when they are not available.

CommentFileSizeAuthor
#6 2885761-6.patch1.2 KBTR
#2 conditions_total_subtotal_calculate-2885761-2.patch901 bytesanrikun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

anrikun created an issue. See original summary.

anrikun’s picture

anrikun CreditAttribution: anrikun commented
Status: Active » Needs review
FileSize
conditions_total_subtotal_calculate-2885761-2.patch901 bytes

Here's a patch.

TR’s picture

TR CreditAttribution: TR commented

Under what circumstances does this condition return the wrong answer?

anrikun’s picture

anrikun CreditAttribution: anrikun commented

When shipping quotes get calculated on op prepare when order has just been created from cart items. At that point, total is always 0 and subtotal is not available yet.

TR’s picture

TR CreditAttribution: TR commented
Component: Orders » Rules

Added Rules component.

TR’s picture

TR CreditAttribution: TR commented
FileSize
2885761-6.patch1.2 KB

So why not always use uc_order_total() to get the total/subtotal in these actions, rather than using it only if our first choice fails?

I would much rather always go through a function call, to make sure all the hooks get invoked etc., rather than trying to access order variables directly and trying to calculate the total/subtotal in our own way in the action.

Does this patch work properly and solve the problem?