The current codebase does not provide support for managing menu links in OG menus from within the node form.
When adding or editing a node, a menu link can only be added / edited in the core menus that are made available for that content type.

In our use case, we also want editors to add menu links to the OG menus they have access to from within this UI.
Since the OG menus are not listed on the content type "available menus" third-party settings form, and given we don't want to manually select the dynamically created OG menus for each content type anyway, some custom code will be needed to achieve this.

CommentFileSizeAuthor
#21 og_menu-n2885625-21.patch19.17 KBDamienMcKenna
#21 og_menu-n2885625-21.interdiff.txt550 bytesDamienMcKenna
#19 og_menu_2885625_19.patch19.17 KBFernly
#18 og_menu_2885625_18.patch18.41 KBFernly
#17 og_menu_2885625_17.patch18.38 KBFernly
#16 interdiff_og_menu_2885625_15-16.txt1.01 KBFernly
#16 og_menu_2885625_16.patch20.58 KBFernly
#15 og_menu_2885625_15.patch17.93 KBFernly
#14 og_menu_2885625_13.patch17.92 KBmpp
#10 og_menu_2885625-10.patch14.17 KBducktape
#7 interdiff.txt660 byteszerolab
#7 og_menu_node_form_2885625-7.patch7.09 KBzerolab
#6 og_menu_node_form_2885625-6.patch7.09 KBautopoietic
#4 og_menu_node_form_2885625-4.patch7.09 KBsvendecabooter
#3 og_menu_node_form_2885625-3.patch6.98 KBsvendecabooter
#2 og_menu_node_form_2885625-2.patch6.89 KBsvendecabooter

Issue fork og_menu-2885625

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

svendecabooter created an issue. See original summary.

svendecabooter’s picture

svendecabooter
Primary language Dutch
Location Gent
CreditAttribution: svendecabooter at Torchbox for The Chartered Society of Physiotherapy, Torchbox commented
Status: Active » Needs review
FileSize
og_menu_node_form_2885625-2.patch6.89 KB

Attached is a patch that provides this functionality.

Included in this patch:
* Updated the OgMenuParentFormSelector service to show both core menus as well as OG menus
* Updated the OgMenuParentFormSelector service to add access control checks for OG menus
* Added extra form_alter logic to set the default menu link retrieved from an OG menu

svendecabooter’s picture

svendecabooter
Primary language Dutch
Location Gent
CreditAttribution: svendecabooter at Torchbox for The Chartered Society of Physiotherapy, Torchbox commented
FileSize
og_menu_node_form_2885625-3.patch6.98 KB

Updated patch that filters out core menus from the parent selector, in case user does not have global permission to manage menus, but still has OG-based permission to manage their specific OG menu instance(s).

svendecabooter’s picture

svendecabooter
Primary language Dutch
Location Gent
CreditAttribution: svendecabooter at Sven Decabooter for The Chartered Society of Physiotherapy, Torchbox commented
FileSize
og_menu_node_form_2885625-4.patch7.09 KB

Updated patch fixes a PHP notice error.

svendecabooter’s picture

svendecabooter
Primary language Dutch
Location Gent
CreditAttribution: svendecabooter at Sven Decabooter for The Chartered Society of Physiotherapy, Torchbox commented
autopoietic’s picture

autopoietic CreditAttribution: autopoietic at Torchbox commented
FileSize
og_menu_node_form_2885625-6.patch7.09 KB

Minor amendment to check in updated patch, to avod potential Undefined index: menu issue.

zerolab’s picture

zerolab CreditAttribution: zerolab at Torchbox for The Chartered Society of Physiotherapy commented
FileSize
og_menu_node_form_2885625-7.patch7.09 KB
interdiff.txt660 bytes

Here is a new patch that fixes an incorrect permissions

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting commented
Status: Needs review » Needs work 
+++ b/og_menu.module
@@ -113,5 +115,105 @@ function og_menu_module_implements_alter(&$implementations, $hook) {
+function og_menu_form_node_form_alter(&$form, FormStateInterface $form_state) {

Can we do this on a base entity alter form? That way this is supported for things beside nodes?

mpp’s picture

mpp CreditAttribution: mpp at AmeXio for District09 commented

It might make sense to limit the list of og menu's to the ones for the current group(s).

Someone could change the group(s) on the node edit so I presume it is not possible to make this solution generic?

ducktape’s picture

ducktape CreditAttribution: ducktape at District09 commented
Status: Needs work » Needs review
FileSize
og_menu_2885625-10.patch14.17 KB

I replaced the MenuParentFormSelector service with a form alter to only load the groups that are applicable to the node, as the service is not aware of any OG context.

mpp’s picture

mpp CreditAttribution: mpp at AmeXio for District09 commented

Can we do this on a base entity alter form? That way this is supported for things beside nodes?

@heddn, not sure if we want to support attaching entities other than Node to the menu?

@ducktape:
Note the array() => [] notation

+  else {
+    if ($placeholder) {

=> elseif ($placeholder) {
https://www.drupal.org/docs/develop/standards/coding-standards#controlst...

+        '#empty_option' => 'Kies een thema',

=> t('Choose a group')

mpp’s picture

mpp CreditAttribution: mpp at AmeXio for District09 commented
Status: Needs review » Needs work

@ducktape, we should use a build callback on submit (setRebuild) to fill the #options list.

  • mpp committed aba74a7 on feature/2885625 
    #2885625 Add support for menu_ui node form widget
mpp’s picture

mpp CreditAttribution: mpp at AmeXio for District09 commented
FileSize
og_menu_2885625_13.patch17.92 KB

Rerolling #10.

Fernly’s picture

Fernly CreditAttribution: Fernly at Dropsolid for District09 commented
FileSize
og_menu_2885625_15.patch17.93 KB

Replaced deprecated entity.manager service by entity_type.manager.

Fernly’s picture

Fernly CreditAttribution: Fernly at Dropsolid for District09 commented
FileSize
og_menu_2885625_16.patch20.58 KB
interdiff_og_menu_2885625_15-16.txt1.01 KB

Changed ogmenu_instance access() check to userAccessEntity() in og_menu.module. The check always returned "forbidden".

Fernly’s picture

Fernly CreditAttribution: Fernly at Dropsolid for District09 commented
FileSize
og_menu_2885625_17.patch18.38 KB

Updated patch for latest dev release.
Changes in src/Form/OgMenuInstanceForm.php are removed from patch because already committed.

Fernly’s picture

Fernly CreditAttribution: Fernly at Dropsolid for District09 commented
FileSize
og_menu_2885625_18.patch18.41 KB

Fix missing menu_name array key in og_menu_get_menu_link_defaults().

Fernly’s picture

Fernly CreditAttribution: Fernly at Dropsolid for District09 commented
FileSize
og_menu_2885625_19.patch19.17 KB

Rerolled patch for Drupal 10

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

The logic here interferes with core's standard node form logic.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Version: 8.x-1.x-dev » 2.x-dev
Status: Needs work » Needs review
FileSize
og_menu-n2885625-21.interdiff.txt550 bytes
og_menu-n2885625-21.patch19.17 KB

I'm not sure why og_menu_form_node_form_alter() includes logic to force $form['menu']['enabled']['#default_value'] to be TRUE on new nodes, so this changes it subtly.