CommentFileSizeAuthor
#7 next_url_pagination-2885543-7.patch5.63 KBKarlShea
#5 next_url_pagination-2885543-5.patch5.31 KBmarkdorison
#4 next_url_pagination-2885543-4.patch3.25 KBmarkdorison
#2 next_url_pagination-2885543-2-tests-only.patch1.75 KBmarkdorison
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markdorison created an issue. See original summary.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Active » Needs review
Issue tags: -Needs tests
FileSize
next_url_pagination-2885543-2-tests-only.patch1.75 KB

Status: Needs review » Needs work

The last submitted patch, 2: next_url_pagination-2885543-2-tests-only.patch, failed testing. View results

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Needs work » Needs review
FileSize
next_url_pagination-2885543-4.patch3.25 KB
markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
FileSize
next_url_pagination-2885543-5.patch5.31 KB
KarlShea’s picture

KarlShea
he/him
Primary language English
Location Minneapolis 🇺🇸
CreditAttribution: KarlShea at Weil Street Digital commented

Nice, I should have looked at the Pager class, the way I was doing it didn't seem great.

KarlShea’s picture

KarlShea
he/him
Primary language English
Location Minneapolis 🇺🇸
CreditAttribution: KarlShea at Weil Street Digital commented
FileSize
next_url_pagination-2885543-7.patch5.63 KB

Reroll

  • KarlShea committed 76d4749 on 8.x-1.x authored by markdorison 
    Issue #2885543 by markdorison, KarlShea: next_url pagination attribute...
KarlShea’s picture

KarlShea
he/him
Primary language English
Location Minneapolis 🇺🇸
CreditAttribution: KarlShea at Weil Street Digital commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.