Coding Standard issues [#2885389]

There are some coding standard issues in module.

Comment	File	Size	Author
#9	coding_standard-fixing-2885389-9.patch	1.9 KB	rohit.rawat619
#9	7.x-1.x: PHP 7.4.x-dev & MySQL 5.7, D7 Build Successful
#5	coding_standard_issue_fixed-2885389-5.patch	16.78 KB	Anupam_Dhauria
#5
#2	dream_permissionscodingstandard-2885389-2.patch	13.9 KB	jayesh_makwana
#2
	dream_permissions.txt	7.14 KB	jayesh_makwana

Issue fork dream_permissions-2885389

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

2885389-coding-standard-issues compare
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

12 June 2017 at 11:21

jayesh_makwana created an issue. See original summary.

Comment #2

jayesh_makwana CreditAttribution: jayesh_makwana at cmsMinds commented 12 June 2017 at 11:22

File	Size
dream_permissionscodingstandard-2885389-2.patch	13.9 KB

We create a patch for solving coding standard issues for this module. Please check and apply it.

Comment #3

Anupam_Dhauria CreditAttribution: Anupam_Dhauria at Valuebound for Valuebound commented 21 July 2022 at 04:01

Assigned:	jayesh_makwana	» Anupam_Dhauria
Status:	Active	» Needs review

Hi @jayesh_makwana,
Thanks for the patch . I will review this.

Comment #4

Anupam_Dhauria CreditAttribution: Anupam_Dhauria at Valuebound for Valuebound commented 21 July 2022 at 04:05

Status:

Needs review

» Needs work

Hii @jayesh_makwana,
your patch applied cleanly.

win10@DESKTOP-VCMGGU5 MINGW64 /c/xampp/htdocs/DRUPAL CONTRIB/drup8/web/modules/contrib/dream_permissions-2885389 (2885389-coding-standard-issues)
$ git apply -v dream_permissionscodingstandard-2885389-2.patch
Checking patch dream_permissions.module...
Checking patch src/Controller/Controller.php...
Checking patch src/Form/AdminPageForm.php...
Checking patch src/Form/DreamPermissions.php...
Applied patch dream_permissions.module cleanly.
Applied patch src/Controller/Controller.php cleanly.
Applied patch src/Form/AdminPageForm.php cleanly.
Applied patch src/Form/DreamPermissions.php cleanly.

But Still I am getting errors.

win10@DESKTOP-VCMGGU5 MINGW64 /c/xampp/htdocs/DRUPAL CONTRIB/drup8/web/modules/contrib
$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig dream_permissions-2885389/

FILE: C:\xampp\htdocs\DRUPAL CONTRIB\drup8\web\modules\contrib\dream_permissions-2885389\css\dream_permissions.css
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\DRUPAL CONTRIB\drup8\web\modules\contrib\dream_permissions-2885389\dream_permissions.info.yml
-------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-------------------------------------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\DRUPAL CONTRIB\drup8\web\modules\contrib\dream_permissions-2885389\dream_permissions.module
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\DRUPAL CONTRIB\drup8\web\modules\contrib\dream_permissions-2885389\src\Controller\Controller.php
----------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
 18 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
 62 | WARNING | [x] '@TODO split in 2 parts: logic and json.' should match the format '@todo Fix problem X here.'
 71 | WARNING | [ ] Role::load calls should be avoided in classes, use dependency injection instead
 95 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\DRUPAL CONTRIB\drup8\web\modules\contrib\dream_permissions-2885389\src\Form\AdminPageForm.php
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
 15 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\DRUPAL CONTRIB\drup8\web\modules\contrib\dream_permissions-2885389\src\Form\DreamPermissions.php
----------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  15 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
 225 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------

Time: 1.58 secs; Memory: 12MB

Moving to need work. I am working on it.

Comment #5

Anupam_Dhauria CreditAttribution: Anupam_Dhauria at Valuebound for Valuebound commented 21 July 2022 at 04:21

Assigned:	Anupam_Dhauria	» Unassigned
Status:	Needs work	» Needs review

File	Size
coding_standard_issue_fixed-2885389-5.patch	16.78 KB

Hi,
I have worked on this issue.
providing patch for review.

Thanks

win10@DESKTOP-VCMGGU5 MINGW64 /c/xampp/htdocs/DRUPAL CONTRIB/drup8/web/modules/contrib
$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig dream_permissions-2885389/

win10@DESKTOP-VCMGGU5 MINGW64 /c/xampp/htdocs/DRUPAL CONTRIB/drup8/web/modules/contrib
$ phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig dream_permissions-2885389/

No fixable errors were found

Time: 924ms; Memory: 12MB