I have been using the Administration Menu module on a Domain Access site and have noticed that the module's default menu caching means that menu items are incorrect when I switch between domains (they are cached with a particular base URL).

File admin_menu.module includes a call to variable_get('admin_menu_cache_server', TRUE);, which always returns true as it appears there is no way of creating or updating this variable via the UI. It seems to me that it would make sense for this variable to be configured in the settings form alongside the option to toggle client-side caching.

I'd be happy to commit a patch for this but I'd first like to know if there is a reason why this variable has been made non-configurable. I couldn't find anything relevant in the commit history.

Comments

S Payne created an issue. See original summary.

S Payne’s picture

Issue summary: View changes
S Payne’s picture

Issue summary: View changes
S Payne’s picture

As per my original comment this may require further discussion, but I have created a patch for this issue

S Payne’s picture

Version: 7.x-3.0-rc5 » 7.x-3.x-dev
Status: Active » Needs review