See #288037: Change link in post for the confused background for this issue. ;)

I just checked and the only roles with the 'edit own forum topics' permission are 'administrator' and 'site maintainer'.

However, authenticated users can 'edit own book pages', edit their own comments, and edit their own projects and release nodes.

Is this an access control bug on d.o, or is there some good reason normal users can't edit their own forum topics? Seems like it'd cut down on lots of silly maintainer support issues with all the "please remove my email address" or "please change the hostname" or "please remove the confidential information I foolishly posted", etc, etc requests.

Thoughts/objections?

Thanks,
-Derek

Comments

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

In Drupal 5, 'edit own' also gives you 'delete own' - IMO in a discussion forum it's a very bad thing if someone can delete a topic they've started, that 200 other people may have commented on. It's easy enough to get rid of the delete button, and it's fixed in Drupal6, so otherwise I'd support it. And for project issues too.

Wolfflow’s picture

Wolfflow CreditAttribution: Wolfflow commented

So Derek

You know now Why I do not have the rights to correct my own Link. I'm sure not such an expert to apply for a Web Master Account , but I love Drupal.org and even, my small contributions in Support and sometimes in Handbooks, could be worth One Little access Right to correct my own mistakes.

Cheers ;-)

BioALIEN’s picture

BioALIEN CreditAttribution: BioALIEN commented
Title: Why don't authenticated users have 'edit own forum topics' permissions? » Allow users to have 'edit own forum topics' permissions
Status: Active » Postponed

Hmm, interesting decision. I'm postponing this till after d.o is upgraded to D6.x

newbuntu’s picture

newbuntu CreditAttribution: newbuntu commented

What if someone accidentally posted some private information and want it to be changed? I know the simple answer is "stupid you", it is internet :( I guess that happened to me. http://drupal.org/node/341969. Can any of the super users here help out?

All I did was trying to help, and posted some user tip which cost me a whole evening to figure out. Can there be some sort of queue to allow users to request a change when "accident" happens? I can see how that can open a can of worms. Honestly, I don't know what's the best answer.

What about a time delay? To give the author a 'remorse' period, say 30 minutes? or before any comments are made, the author can still make changes?

I try to be careful, but accident does happen. If it's a comment, I still have chance to correct. If it's original post. Oops, it's gone :(

dww’s picture

dww
we/he/they
CreditAttribution: dww commented

Yes, that's exactly the case I'm talking about when I posted this request in the first place. And sure, I just edited your other post.

No, looks like it'd be dumb to spend time on alternative solutions. Once we upgrade d.o to D6, we'll have separate perms for "edit own ..." and "delete own ..." and the problem will be solved.

newbuntu’s picture

newbuntu CreditAttribution: newbuntu commented

Thanks a lot for saving my embarrassment!

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Assigned: Unassigned » dww
Status: Postponed » Needs review

d.o is on D6. We're now 4 clicks away from having this fixed. Any objections?

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented

With comments you can only edit until there is a reply - can we do something similar with forum topics?

dww’s picture

dww
we/he/they
CreditAttribution: dww commented

not with 4 clicks. ;) we'd have to do some custom mojo in drupalorg -- perhaps hook_menu_alter() and change the perms on the edit tab based on the # of comments on the forum node.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented

yep - not hard though.

add1sun’s picture

add1sun CreditAttribution: add1sun commented

I'd say do the four clicks now and editing after comments can be added by someone with time to deal with it later. It is a horribly annoying problem that now has a clickable solution. :-)

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Status: Needs review » Fixed

4 clicks completed. ;)
#389718: Prevent users from editing their own forum post once there are replies for interested parties.
Yay.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

We had a discussion on this on the infra list and also, seen #404848: I though users could not edit forum topics popping up, lamenting whether it was a good idea to open editing on forum topics. I don't think it is a good idea.

nevets’s picture

nevets CreditAttribution: nevets commented

I posted #404848 and it came from a user editing a topic and removing all the detail.

dww’s picture

dww
we/he/they
CreditAttribution: dww commented

@Gabor: then either:

A) Roll the (trivial) patch for #389718: Prevent users from editing their own forum post once there are replies

or

B) Set aside an hour a week of your time to resolve issues like #288037: Change link in post and revert this change.

;)

VM’s picture

VM CreditAttribution: VM commented

an example of this being problematic = http://drupal.org/node/131113

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Just marked #417544: Why lettiing people edit their own posts is a bad idea a duplicate. Another example of the harm this change in itself done.