Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This bug is 3 fold:
1) Forms added in beta12 or below can no longer be submitted after upgrading to beta13 because:
2) If a user configures a webform through the UI and doesn't click the fairly hidden "Edit submit buttons" link, the Webform still shows a submit button but pressing it does nothing except reload the page. Debugging into it, the WebformSubmissionForm::submitForm function isn't even executed
3) If a user fails to configure the Submit button label while editing the submit buttons for a form the above also happens.
Reverting to beta12 fixes the issue. I can't seem to replicate the problem on simplytest.me which leads me to believe there's some config that may have not been set on the upgrade?
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | webform.webform.media_enquiries.yml.txt | 3.02 KB | acbramley |
Comments
Comment #2
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedCan you please export and upload a broken form so that I can take a look at it.
Comment #3
acbramley CreditAttribution: acbramley at PreviousNext for Transport for NSW commentedSure, sorry should've thought of that! For some reason I can only reproduce it with this certain form so maybe it's something to do with one of the elements on it.
Comment #4
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedI can't reproduce the issue. My best guess is that the issue is related to your theme, Do you still have problems when switching to Bartik?
Comment #5
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedI agree.
@see #2884316: Improve customizing submit buttons UI/UX
Comment #6
acbramley CreditAttribution: acbramley at PreviousNext for Transport for NSW commentedgood idea, unfortunately I get the same thing in Bartik.
Comment #7
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented...but if you upload your form to a simpletest.me test site is the submit button okay.
Are you using customized form buttons? What happens if you delete the customized form buttons?
Comment #8
acbramley CreditAttribution: acbramley at PreviousNext for Transport for NSW commentedYeah it works fine on the simplytest.me site...
Customised form buttons as in twig overrides? That wouldn't matter when switched to Bartik right?
In any case it must be something funky with our set up.
Comment #9
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedFor the record, I think this change #2878193: Allow actions (aka submit buttons) to be placed anywhere on a webform is causing your regression.