Problem/Motivation

A recent branch test points out that there are CSS coding standards errors in examples: https://www.drupal.org/pift-ci-job/689152

Click the '9 coding standards messages' link to see the errors:

css/examples.icons.css
line 14	Background image '../images/examples.svg' was used multiple times, first declared at line 10, col 3.
field_permission_example/css/field_permission_example.css
10	Expected (<color>) but found '1000'.
17	Values of 0 shouldn't have units specified.
18	Values of 0 shouldn't have units specified.
18	Standard property 'box-shadow' should come after vendor-prefixed property '-moz-box-shadow'.
19	Values of 0 shouldn't have units specified.
19	Standard property 'box-shadow' should come after vendor-prefixed property '-webkit-box-shadow'.
js_example/css/jsweights.css
1	Don't use IDs in selectors.
1	Element (div#js-weights) is overqualified, just use #js-weights without element name.

Proposed resolution

Fix these errors.

How:

  • Identify errors to fix.
  • Submit a patch with those fixes.
  • The testbot result should provide a review of the files changed by the patch.
  • Repeat as needed.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 interdiff-2884172-2-4.txt1.81 KByash_khandelwal
#4 new_updated_coding_standard-2884172-4.patch2.16 KByash_khandelwal
#2 updated_coding_standard-2884172-2.patch2 KByash_khandelwal
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mile23 created an issue. See original summary.

yash_khandelwal’s picture

yash_khandelwal
Primary language English
CreditAttribution: yash_khandelwal as a volunteer and at Iksula commented
Status: Active » Needs review
FileSize
updated_coding_standard-2884172-2.patch2 KB

Patch has been created. Please check.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Needs review » Needs work

Thanks, looks like a good start.

If you click on the test run you'll see there are still errors:

field_permission_example/css/field_permission_example.css
line 17	Values of 0 shouldn't have units specified.
18	Values of 0 shouldn't have units specified.
19	Values of 0 shouldn't have units specified.
js_example/css/jsweights.css
1	Don't use IDs in selectors.
yash_khandelwal’s picture

yash_khandelwal
Primary language English
CreditAttribution: yash_khandelwal as a volunteer and at Iksula commented
Status: Needs work » Needs review
FileSize
new_updated_coding_standard-2884172-4.patch2.16 KB
interdiff-2884172-2-4.txt1.81 KB

Created the new patch and interdiff, please review now.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Needs review » Fixed

Nice, Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.