Lately I was able to fix a few issues with the simpletests, however there's one test that is failing and it needs some attention. I'm not entirely sure why the test is failing.

see test here:
https://dispatcher.drupalci.org/job/drupal_d7/21566/

CommentFileSizeAuthor
#14 media_youtube-2883644-failing-tests.patch481 bytessteinmb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad as a volunteer and commented

Funny, in my local environment, I get a lot of passed tests, however on the testbot, I see no passes, just one fail.

Although, it is the exact same failure as in my local test environment.

https://dispatcher.drupalci.org/job/drupal_d7/21566/testReport/Media%20Y...

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad as a volunteer and commented
Title: Fix head test for 7.x-3.1 » Fix head tests for media_youtube 7.x-3.1
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad as a volunteer and commented

Would be nice to fix this soon.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad as a volunteer and commented

anyone want to take this on? I am having a bit of an issue debugging this.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad as a volunteer and commented

This is highest priority right now.

steinmb’s picture

steinmb CreditAttribution: steinmb as a volunteer commented
Assigned: Unassigned » steinmb
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad as a volunteer and commented

highest priority item

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad as a volunteer and commented

@steinmb
can you please try this again:
php ../../../../scripts/run-tests.sh --class MediaInternetYouTubeTestCase

post the test results here, go from there.

steinmb’s picture

steinmb CreditAttribution: steinmb as a volunteer commented

Hi Josepth.
Back today after taking a little more then a month off (rebooting). Though I'll need a couple of days to get inbox zero and up to speed :)

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad as a volunteer and commented

@steinmb, just to let you know, I've created an updated distribution release of media_dev , this includes media_youtube , you can download it on there and run simpletests with that, this should help us with debugging. I'll probably put out a new media_dev release soon with the latest releases (many contrib updates lately) .

Here's the media_dev project

try it out on simplytest.me

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad as a volunteer and commented

Steinmb , any luck with this?

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad as a volunteer and commented

still is an issue. I'm very busy these days but I will review any patch for this.

steinmb’s picture

steinmb CreditAttribution: steinmb as a volunteer commented
Version: 7.x-3.1 » 7.x-3.x-dev
Status: Needs work » Needs review
FileSize
media_youtube-2883644-failing-tests.patch481 bytes

Thank you for the reminder. Competently forgot about this. Sorry.
It fails on two of the parameters. Not sure if the default parameter that get rendered have changed. The test is looking for "https://www.youtube.com/embed/9g2U12SsRns?wmode=opaque&controls=1 but the test submission return https://www.youtube.com/embed/9g2U12SsRns?wmode=opaque&controls=&rel=0

This patch tries to address this in the test.

steinmb’s picture

steinmb CreditAttribution: steinmb as a volunteer commented
Assigned: steinmb » joseph.olstad
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad as a volunteer and commented
Status: Needs review » Reviewed & tested by the community

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad as a volunteer and commented
Status: Reviewed & tested by the community » Fixed
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad as a volunteer and commented

Great detective work @steinmb! thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.