[D8] Porting to Drupal 8 - improve unit test coverage

Thank you for your create the issue and your efforts @akashjain132. I appreciate it. I actually have a work-in-progress 8.x-2.x branch in my private repository that incorporates some of my planned architectural changes in #1852834: Possible to have multiple agreements - role based. I had not gotten around to pushing it as I had started working on it before I became a maintainer.

It will probably take me some time to review your work on github to compare it to what I have already, but I would like to try to incorporate any improvements you have there into my own code (with attribution).

At the moment my priority in my free time is to try to incorporate and deal with the merge conflicts around the following feature and bug requests:

- #1852834: Possible to have multiple agreements - role based
- #2873904: Allow more agreement frequency options
- #2374539: Multiple Roles
- #2879720: avoid Drupal API function calls in global context

I don't want to prematurely push the architecture into an official 8.x-2.x branch yet, but I should probably push my 8.x-2.x-WIP branch upstream here at least.

Because I don't have version control access on the agreement project I've pushed my 8.x-2.x work into a public github repository, https://github.com/mradcliffe/agreement.

I would probably re-fork from my repository, and then add some pull requests until we can create a functional patch to squash down here.

Roadmap:

- Re-implement functional tests as FunctionalJavascript tests.
- Add migration templates for Drupal 6 and Drupal 7.

This is functional with tests now on github.

Next step is to get access to create branches on drupal.org so that I can move things back here.

Okay, 8.x-2.x branch created and here's a patch from GitHub.

- Also implements #2374539: Multiple Roles with new functional tests.
- Functional tests ported to PHPUnit.
- Unit test added.

Still needs views integration.

Adds views integration back.

Fixes views schema so that options are set as a sequence instead of a mapping.

Let's get those code standards fixed while I'm at it too.

Updating issue summary to include recently done work.

Here's the start of some migration templates and plugins with a test and fixture that will probably fail.

Still not working, but I forgot the destination plugin for agreement table, which I think I'm doing what I'm supposed to be doing but the API documentation is not really clear.

Fixes the fixture issue and gets it almost there.

- Agreement type migration is working.
- Agreement migration is not working. For some reason even though the agreement destination plugin is firing the import method, nothing is getting inserted into the agreement table. :|

So destinations into a database table aren't supported without migrate_plus? Ugh, so frustrating that it's not documented anywhere and not really obvious given all the other destination plugins. Guess I need to implement my own thing similar to #2769979: Add migrate destination for sql table.

- Removes debug code

- todo: d6 fixture and test to make sure that the optional agreement type gets set where it doesn't exist in d6.

Adds drupal 6 migration. I split the agreement migration into d6/d7 versions because I needed to explicitly add a config. option to the plugin to determine the version. Tags don't seem to be able to be used for this without an extraordinary amount of extra code.

I'm not sure if it's worth it to add a migration of the agreement settings in drupal 6 and I think that could be a follow-up.

Lost the interdiff locally so recreated using interdiff tools.

Updating status and title.

I think that this is good enough for an alpha, but I'll leave this open for expanded unit test coverage since most of the tests are functional.

Adds unit tests for some of the complex logic inside AgreementHandler class. There are still some coverage gaps on the class, but the main complexity should be tested.

Not sure why I needed request time defined, but it probably failed at some point in time when I first started this months ago.

I'm satisfied. Patch is only adding test coverage so that's the last thing I'm going to do for this issue. Additional coverage can probably be added later as bugs are reported and fixed.