When you set a soft limit on a facet, it just considers the number of found items to decide whether to add a Show More link.

Currently in soft-limit.js

 // Add "Show more" / "Show less" links.
    facetsList.once().filter(function () {
      return $(this).find('li').length > limit;
    }).each(function (facet) {...

For hierarchical facets, it should consider the first level items only (or some other logic if made configurable).

CommentFileSizeAuthor
#2 soft_limit_does_not-2883298-2.patch487 bytesborisson_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jummonk created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Dazzle commented
Status: Active » Needs review
FileSize
soft_limit_does_not-2883298-2.patch487 bytes

Untested, but in theory this should fix that issue.

Status: Needs review » Needs work

The last submitted patch, 2: soft_limit_does_not-2883298-2.patch, failed testing. View results

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Dazzle commented

AlreadyInstalledException, retesting

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Dazzle commented
Status: Needs work » Needs review

  • borisson_ committed 99894e2 on 8.x-1.x 
    Issue #2883298 by borisson_: Soft limit does not consider hierarchical...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Dazzle commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.