In file_entity_file_load, we have this code snippet:

  $alt = variable_get('file_entity_alt', '[file:field_file_image_alt_text]');
  $title = variable_get('file_entity_title', '[file:field_file_image_title_text]');

These tokens are not evaluated. Instead the code should be the following:

  $alt = variable_get('file_entity_alt', '[file:field-file-image-alt-text]');
  $title = variable_get('file_entity_title', '[file:field-file-image-title-text]');

Patch attached.

CommentFileSizeAuthor
#16 file_entity-fix-alt-title-token-2882958-16-d8.patch637 bytesgargsuchi
#8 file_entity-fix-alt-title-token-2882958-8-d7.patch624 bytesgargsuchi
#3 file_entity-fix-alt-title-token-2882958-3-d7.patch636 bytesgargsuchi
#3 file_entity-fix-alt-title-token-2882958-3-d8.patch607 bytesgargsuchi
file_entity_token.patch604 bytesgargsuchi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gargsuchi created an issue. See original summary.

gargsuchi’s picture

gargsuchi CreditAttribution: gargsuchi as a volunteer and commented

As a workaround, this also works:

drush vset file_entity_alt '[file:field-file-image-alt-text]'
drush vset file_entity_title '[file:field-file-image-title-text]'

gargsuchi’s picture

gargsuchi CreditAttribution: gargsuchi at Salsa Digital commented
FileSize
file_entity-fix-alt-title-token-2882958-3-d8.patch607 bytes
file_entity-fix-alt-title-token-2882958-3-d7.patch636 bytes

Uploading new patches against the latest develop for D7 and D8 both.

wiifm’s picture

wiifm
Primary language English
Location Wellington, NZ
CreditAttribution: wiifm as a volunteer and at Acquia commented
Related issues: +#1553094: Alt and Title support for Images

Add related issue.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Active » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Version: 7.x-2.0-beta3 » 7.x-2.x-dev
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Needs review » Needs work

Patch fails to apply to 2.x dev

gargsuchi’s picture

gargsuchi CreditAttribution: gargsuchi at Salsa Digital commented
FileSize
file_entity-fix-alt-title-token-2882958-8-d7.patch624 bytes

Uploading D7 patch again.

gargsuchi’s picture

gargsuchi CreditAttribution: gargsuchi at Salsa Digital commented
Status: Needs work » Needs review

D7 patch passes now.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Needs review » Fixed
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

@gargsuchi , thanks for the patch, looks good afaik.

new tagged release hopefully soon.

gargsuchi’s picture

gargsuchi CreditAttribution: gargsuchi at Salsa Digital commented

joseph.olstad
Is there something wrong with the 8.x branch? The test for D8 patch is failing for something that is totally not related to my code changes. The error is "D7 Composer Command Failed".

wiifm’s picture

wiifm
Primary language English
Location Wellington, NZ
CreditAttribution: wiifm as a volunteer and at Acquia commented

@gargsuchi in order to verify the patch for the D8 branch you should:

* re-open this issue
* change the version to 8.x-2.x-dev
* mark as needs review
* click to retest your D8 patch

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Version: 7.x-2.x-dev » 8.x-2.x-dev
Status: Fixed » Needs review

switch to 8.x

gargsuchi’s picture

gargsuchi CreditAttribution: gargsuchi at Salsa Digital commented
FileSize
file_entity-fix-alt-title-token-2882958-16-d8.patch637 bytes

New D8 patch.

gargsuchi’s picture

gargsuchi CreditAttribution: gargsuchi at Salsa Digital commented

@joseph.olstad
It seems that there is something wrong with the D8 dev branch tests. The failure of D8 patch is totally not related to my changes.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

See
#2892203: Fix tests for 8.3 core

  • gargsuchi authored c9f1c2c on 8.x-2.x 
    Issue #2882958 by gargsuchi: Tokens [file:field_file_image_alt_text] and...
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Needs review » Fixed

Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.