Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Chosen strings are not translatable. Are we should to add them as translatable markup?
$options = array(
'disable_search' => (bool) $chosen_conf->get('disable_search'),
'disable_search_threshold' => (int) $chosen_conf->get('disable_search_threshold'),
'search_contains' => (bool) $chosen_conf->get('search_contains'),
'placeholder_text_multiple' => new TranslatableMarkup($chosen_conf->get('placeholder_text_multiple')),
'placeholder_text_single' => new TranslatableMarkup($chosen_conf->get('placeholder_text_single')),
'no_results_text' => new TranslatableMarkup($chosen_conf->get('no_results_text')),
'inherit_select_classes' => TRUE,
);
Comment | File | Size | Author |
---|---|---|---|
#6 | 2882707-6.patch | 1.42 KB | dmitri.daranuta |
#5 | 2882707-5.patch | 1.33 KB | ant1 |
#4 | chosen_strings_are_not_translatable-2882707-4.patch | 1.29 KB | a.sotirov |
| |||
#2 | chosen_strings_are_not_translatable-2882707-2.patch | 1.21 KB | ElegguaDP |
Comments
Comment #2
ElegguaDP CreditAttribution: ElegguaDP commentedComment #3
nagy.balint CreditAttribution: nagy.balint commentedI can add a translation at admin/config/user-interface/chosen/translate
Does it not work?
Comment #4
a.sotirov CreditAttribution: a.sotirov at FFW commentedHi all,
I would like to suggest a patch for the 8.x-2.9 version on the module. I hope it will be helpful for someone
Comment #5
ant1Reroll for 8.x-2.10
Comment #6
dmitri.daranuta CreditAttribution: dmitri.daranuta at FFW commentedReroll for 3.0.x
Comment #7
nagy.balint CreditAttribution: nagy.balint commentedI am still unsure about why we need this patch.
In theory since I can translate the config on the Drupal translation interface, and get returns the translated version, then these TranslatableMarkup would not be needed.
Comment #8
artematem CreditAttribution: artematem at FFW commentedConfirming that config_translation can do this job and no patch is needed.
Comment #9
artematem CreditAttribution: artematem at FFW commented