Comments

brahmjeet789 created an issue. See original summary.

brahmjeet789’s picture

Pleas test the code after clean the code.

Status: Needs review » Needs work

The last submitted patch, 2: 2882642-clean-up-code-1.patch, failed testing.

harsha012’s picture

Fixed the short array syntax and $this->t() issue is fixed in this patch

harsha012’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: code-cleanup-2882642-04.patch, failed testing.

harsha012’s picture

harsha012’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: code-cleanup-2882642-05.patch, failed testing.

hgunicamp’s picture

I posted a new patch improving the 'code-cleanup-2882642-05.patch' one.

hgunicamp’s picture

Status: Needs work » Needs review
Issue tags: +ciandt-contrib

Status: Needs review » Needs work

The last submitted patch, 10: clean_up_the_codebase-2882642-10.patch, failed testing. View results

hgunicamp’s picture

Sorry. Typo in my previous patch.

Status: Needs review » Needs work

The last submitted patch, 13: clean_up_the_codebase-2882642-13.patch, failed testing. View results

Berdir’s picture

HPUnit_Framework_Exception: PHP Fatal error: Declaration of Drupal\token\Token::getInvalidTokens() must be compatible with Drupal\token\TokenInterface::getInvalidTokens($type, array $tokens) in

+++ b/src/TokenInterface.php
@@ -56,7 +56,7 @@ interface TokenInterface {
    *   An array with the invalid tokens in their original raw forms.
    */
-  function getInvalidTokens($type, $tokens);
+  public function getInvalidTokens($type, array $tokens);
 

You are changing an interface which breaks its implementation that you are not updating. That's why it is failing.

This is a functional change, I know there is a coding style for this but it's problematic as it results in an API change, so lets keep those kind of argument changes out of htis issue.