Convert module to use short array syntax (new coding standard). [#2882149]

Simplify module needs to be converted to use short array syntax as per new coding standard.

Comment	File	Size	Author
#3	interdiff.txt	4.3 KB	amit.drupal
#3	short_array_syntax-2882149-3.patch	30.24 KB	amit.drupal
#3	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 Skipped, branch did not pass for 4 weeks PHP 5.5 & PostgreSQL 9.1, D8.4 Skipped, branch did not pass for 4 weeks PHP 5.5 & SQLite 3.8, D8.4 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D8.4 Skipped, branch did not pass for 4 weeks PHP 7 & MySQL 5.5, D8.4 Skipped, branch did not pass for 4 weeks PHP 7 & PostgreSQL 9.1, D8.4 Skipped, branch did not pass for 4 weeks PHP 7 & SQLite 3.14, D8.4 Skipped, branch did not pass for 4 weeks
#2	short_array_syntax-2882149-2.patch	30.93 KB	Munavijayalakshmi
#2	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 Skipped, branch did not pass for 4 weeks PHP 5.5 & PostgreSQL 9.1, D8.4 Skipped, branch did not pass for 4 weeks PHP 5.5 & SQLite 3.8, D8.4 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D8.4 Skipped, branch did not pass for 4 weeks PHP 7 & MySQL 5.5, D8.4 Skipped, branch did not pass for 4 weeks PHP 7 & PostgreSQL 9.1, D8.4 Skipped, branch did not pass for 4 weeks PHP 7 & SQLite 3.14, D8.4 Skipped, branch did not pass for 4 weeks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

29 May 2017 at 11:56

Munavijayalakshmi created an issue. See original summary.

Comment #2

Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound commented 29 May 2017 at 11:59

Assigned:	Munavijayalakshmi	» Unassigned
Status:	Active	» Needs review

File	Size
short_array_syntax-2882149-2.patch	30.93 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 Skipped, branch did not pass for 4 weeks PHP 5.5 & PostgreSQL 9.1, D8.4 Skipped, branch did not pass for 4 weeks PHP 5.5 & SQLite 3.8, D8.4 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D8.4 Skipped, branch did not pass for 4 weeks PHP 7 & MySQL 5.5, D8.4 Skipped, branch did not pass for 4 weeks PHP 7 & PostgreSQL 9.1, D8.4 Skipped, branch did not pass for 4 weeks PHP 7 & SQLite 3.14, D8.4 Skipped, branch did not pass for 4 weeks

File

Size

short_array_syntax-2882149-2.patch

30.93 KB

Comment #3

amit.drupal CreditAttribution: amit.drupal as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented 30 May 2017 at 09:16

File	Size
short_array_syntax-2882149-3.patch	30.24 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 Skipped, branch did not pass for 4 weeks PHP 5.5 & PostgreSQL 9.1, D8.4 Skipped, branch did not pass for 4 weeks PHP 5.5 & SQLite 3.8, D8.4 Skipped, branch did not pass for 4 weeks PHP 5.6 & MySQL 5.5, D8.4 Skipped, branch did not pass for 4 weeks PHP 7 & MySQL 5.5, D8.4 Skipped, branch did not pass for 4 weeks PHP 7 & PostgreSQL 9.1, D8.4 Skipped, branch did not pass for 4 weeks PHP 7 & SQLite 3.14, D8.4 Skipped, branch did not pass for 4 weeks
interdiff.txt	4.3 KB

Thanks @Munavijayalakshmi! The patch from #2 doesn't replace all arrays to short syntax. Attached a patch that does this.

Comment #4

deepakkumar14 CreditAttribution: deepakkumar14 as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented 30 May 2017 at 10:51

Status:

Needs review

» Reviewed & tested by the community

amit.drupal i have tested the patch in #3 and its work fine.
it replaces all the arrays to short syntax.

Comment #5

nord102

he/him

English

CreditAttribution: nord102 at Northern Commerce commented 22 October 2019 at 19:09

Status:

Reviewed & tested by the community

» Closed (duplicate)

I was not able to apply the patch in #3, I was going to update this ticket with a re-rolled patch, but I opted to make a new ticket to update the module to follow Drupal Coding Standards, including the array syntax https://www.drupal.org/project/simplify/issues/3089490

Closing this ticket as a duplicate