Problem/Motivation

The type and ID for JSON API schemas are not present.

Proposed resolution

Add the pertinent normalizers to add them.

CommentFileSizeAuthor
#3 2882116--type-id-normalizers.patch7.1 KBtedbow
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

e0ipso created an issue. See original summary.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Status: Active » Needs review

https://github.com/phase2/schemata/pull/20

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Acquia commented
FileSize
2882116--type-id-normalizers.patch7.1 KB

@e0ipso did another against yours to update the test expectation files.

Uploading a patch so tests run

Grayside’s picture

Grayside CreditAttribution: Grayside at Phase2 commented

Do the patch and the PR match?

(Currently re-thinking role of Github in all this...)

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Acquia commented

@Grayside yep @e0ipso pulled in my changes https://github.com/e0ipso/schemata/pull/1

Yeah it's tricky making sure both are in sync. I mostly posted here so tests could run.

Grayside’s picture

Grayside CreditAttribution: Grayside at Phase2 commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.