Notice : Undefined index: group in metatag_views_i18n_object_info() [#2882048]

The issue has been detected in the version 7.x-1.21 but the problematic code is still present in the dev version.

When Metatag is enabled with I18n, I got this message: Notice : Undefined index: group in metatag_views_i18n_object_info() (line 69 of /modules/contrib/metatag/metatag_views/metatag_views.i18n.inc ). when we have custom metatags (via code) that have no group defined.

I have checked elsewhere to see if metatags require the definition of a group and I saw that in the file metatag.i18n.inc, the code treats the group as optional (see in the hook "metatag_i18n_object_info()"). I noticed the same in metatag_token_info() (see the file metatag.token.inc).

So, that means the definition of a group for a metatag is optional and then, the "metatag_views_i18n_object_info()" hook in metatag_views.i18n.inc must take into account too.

By screening the rest of the code, I saw the same problem for metatag_context and metatag_panels.

I am working on a patch.

Comment	File	Size	Author
#5	undefined_group_in_i18n-2882048-5.patch	2.99 KB	jyraya
#5	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 271 pass PHP 5.6 & MySQL 5.5, D7 271 pass
#4	undefined_group_in_i18n-2882048-4.patch	3.07 KB	jyraya
#4	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 271 pass PHP 5.6 & MySQL 5.5, D7 271 pass
#2	undefined_group_in_i18n-2882048-2.patch	3.19 KB	jyraya
#2	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 271 pass PHP 5.4 & MySQL 5.5, D7 271 pass PHP 5.5 & MySQL 5.5, D7 271 pass PHP 5.5 & PostgreSQL 9.1, D7 269 pass, 1 fail PHP 5.5 & SQLite 3.8, D7 246 pass, 66 fail PHP 5.6 & MySQL 5.5, D7 271 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

29 May 2017 at 06:31

jyraya created an issue. See original summary.

Comment #2

jyraya CreditAttribution: jyraya as a volunteer commented 29 May 2017 at 12:11

File	Size
undefined_group_in_i18n-2882048-2.patch	3.19 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 271 pass PHP 5.4 & MySQL 5.5, D7 271 pass PHP 5.5 & MySQL 5.5, D7 271 pass PHP 5.5 & PostgreSQL 9.1, D7 269 pass, 1 fail PHP 5.5 & SQLite 3.8, D7 246 pass, 66 fail PHP 5.6 & MySQL 5.5, D7 271 pass

The patch is ready for review

Comment #3

jyraya CreditAttribution: jyraya as a volunteer commented 29 May 2017 at 12:11

Status:

Active

» Needs review

Comment #4

jyraya CreditAttribution: jyraya as a volunteer commented 30 May 2017 at 08:19

File	Size
undefined_group_in_i18n-2882048-4.patch	3.07 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 271 pass PHP 5.6 & MySQL 5.5, D7 271 pass

Here a new patch with code improvement suggested by my colleague @Voidtek

Comment #5

jyraya CreditAttribution: jyraya as a volunteer commented 30 May 2017 at 12:00

File	Size
undefined_group_in_i18n-2882048-5.patch	2.99 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 271 pass PHP 5.6 & MySQL 5.5, D7 271 pass

Ok, last improvement :-)

Comment #6

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 4 June 2017 at 23:50

Version:	7.x-1.21	» 7.x-1.x-dev
Component:	Code	» Multilingual/intl

Ok, but is there any reason to not put them in a group? Out of interest, but what service are they for?

Comment #7

5 June 2017 at 02:08

DamienMcKenna committed aeefd3d on 7.x-1.x authored by jyraya

Issue #2882048 by jyraya: i18n integration shouldn't assume a tag has a...

Comment #8

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 5 June 2017 at 02:08

Status:	Needs review	» Fixed
Parent issue:		» #2853846: Plan for Metatag 7.x-1.22 release

Thanks. Committed!

Comment #9

jyraya CreditAttribution: jyraya as a volunteer commented 5 June 2017 at 07:59

In the case where we have detected the problem, we defined meta tags designed for several internal services. Defining a group for each of them would obliges us to have a group per meta tag that would be meaningless for users.

That's why we did not defined a group like the module let us do it... except these 3 sub-modules.

Thank you very much to have treat it our ticket.