The Admin Status form on the admin_status.services.yml file needs to be updated for coding standards.

CommentFileSizeAuthor
#2 admin_status-update-form-code-standards-2881752-2.patch8.39 KBlegaudinier
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

legaudinier created an issue. See original summary.

legaudinier’s picture

legaudinier CreditAttribution: legaudinier at Hook 42 commented
Assigned: legaudinier » Unassigned
Status: Needs work » Needs review
FileSize
admin_status-update-form-code-standards-2881752-2.patch8.39 KB

Updated the Admin Status form on the admin_status.services.yml file for coding standards.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
CreditAttribution: volkswagenchick at Hook 42 commented
Status: Needs review » Needs work

Thanks for the patch! One nitpick:

+++ b/src/Form/AdminStatusForm.php
@@ -17,23 +21,32 @@ class AdminStatusForm extends ConfigFormBase {
+  public function __construct(ConfigFactoryInterface $config_factory, PluginManagerInterface $pluginManager) {

Line is longer than 80 characters

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Status: Needs work » Reviewed & tested by the community

The 80 char requirement is for comments, not code. Marking RTBC.

Kristen Pol credited chrisdarke42@gmail.com.

Kristen Pol credited loopduplicate.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented

Thanks for the patch. This work was also worked on and reviewed by @loopduplicate and Chris Darke so making sure they get credit as well.

Kristen Pol credited ChrisDarke.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented

Maybe wrong Chris... trying again.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
CreditAttribution: volkswagenchick at Hook 42 commented
Status: Reviewed & tested by the community » Needs work

I was unable to apply the patch successfully using SimplyTest. Marking as need work.

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.