Hi,

Its a good module and i like the concept to override .htaccess file instead changing server's php.ini file.
While using module, i came to know the custom variables are not getting deleted when uninstalling module.

CommentFileSizeAuthor
#2 removed_variables_after_uninstall-2881748-2.patch3.25 KBhemant.joshi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joshihemant2007 created an issue. See original summary.

hemant.joshi’s picture

hemant.joshi
Location India, Pune
CreditAttribution: hemant.joshi as a volunteer and at InfoBeans Technologies Limited commented
Assigned: hemant.joshi » Unassigned
Status: Active » Needs review
FileSize
removed_variables_after_uninstall-2881748-2.patch3.25 KB

Patch File created.

Removed variables after module uninstall.

Sahil Gupta’s picture

Sahil Gupta CreditAttribution: Sahil Gupta as a volunteer commented

Hi there,

Thank you for admiring the concept of module and reporting this bug. I have committed your changes.

Sahil Gupta’s picture

Sahil Gupta CreditAttribution: Sahil Gupta as a volunteer commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

hemant.joshi’s picture

hemant.joshi
Location India, Pune
CreditAttribution: hemant.joshi as a volunteer and at InfoBeans Technologies Limited commented

@Sahil Gupta

Thank you for the module.

I am helping out on Drupal.org, could you go back and give me a credit for the patch?? The box next to my name just gets ticked and i will get a credit! (Karma). I see it as a way of incentive to help get involved it the community! It takes a village.

Cheers!

Sahil Gupta’s picture

Sahil Gupta CreditAttribution: Sahil Gupta as a volunteer commented

Hi There,

credited, you should be able to see it now.

Thanks!

Sahil Gupta’s picture

Sahil Gupta CreditAttribution: Sahil Gupta as a volunteer commented