Scroll Progress is a page scroll indication

It provides a beatiful progress indicator for page scroll.

Current version of the module allows you to choose any of the 4 available Scroll themes.
You can choose color scheme for indication.

Themes are as follow:

Straight line
Circular progress
Animated progress
Tooltip progress
Bottom progress bar


Review

https://www.drupal.org/node/2881405#comment-12124308
https://www.drupal.org/node/2597211#comment-12124328

git clone --branch 7.x-1.x https://git.drupal.org/project/scroll_progress.git

progress
progress
progress
progress
progress

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

keshav.k created an issue. See original summary.

keshavv’s picture

Issue summary: View changes

Creating module that shows the progress bar on the top of the page when user scroll down the page. This will be useful to indicate the height of the page.
Module link https://www.drupal.org/project/scroll_progress

PA robot’s picture

Status: Active » Needs work

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

keshavv’s picture

Title: Scroll progress » [D7] Scroll progress
Issue summary: View changes
keshavv’s picture

Issue summary: View changes
keshavv’s picture

Issue summary: View changes
keshavv’s picture

Status: Needs work » Needs review
keshavv’s picture

Issue summary: View changes
pankajsachdeva’s picture

Assigned: Unassigned » pankajsachdeva
pankajsachdeva’s picture

Hi keshav,

I reviewed your module and found few o things which you have to imporve.

Automated Review

Found various issues in pareview.sh. Follow this link to know the issues:
https://pareview.sh/node/1911

Manual Review

Individual user account
[Yes: Follows] the guidelines for individual user accounts.
No duplication
[Yes: Does not cause] module duplication and/or fragmentation.
Master Branch
[Yes: Follows] the guidelines for master branch.
Licensing
[Yes: follow] the licensing requirements.
3rd party assets/code
[Yes: Follows] the guidelines for 3rd party assets/code.
README.txt/README.md
[No: Does not follow] the guidelines for in-project documentation and/or the README Template.
Please provide detail information about your module like whats the functionality of module, Requirements, installation steps etc.
Code long/complex enough for review
[No: Doesn't Follow] the guidelines for project length and complexity.
Secure code
[Yes: Meets the security requirements]
Coding style & Drupal API usage
[Suggestions:
  1. Please write scroll_progress_uninstall() in .install file. Also delete all the variables on uninstall of a module.
  2. Provide proper comments on hooks/functions. What is their functionality.
  3. Implement hook_help()

I also download and enable the module for testing the module functionality. Functionlity is working properly.

pankajsachdeva’s picture

Assigned: pankajsachdeva » Unassigned
Status: Needs review » Needs work
pankajsachdeva’s picture

keshavv’s picture

Issue summary: View changes
FileSize
40.25 KB
keshavv’s picture

Many thanks @pankajsachdeva . I will fix this and push it again

keshavv’s picture

Status: Needs work » Needs review

I had fixed all coding standard and other stuff . Please review again

PA robot’s picture

Issue summary: View changes

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

Yogesh Kushwaha’s picture

HI keshv.k,

here is my manual code review.

  • Use proper file commnet on .install file. You have written hook comment on file comment area.
  • On .module file write proper @file comment
  • Code should not exceed 80 character limit please Read Guideline
keshavv’s picture

Issue summary: View changes

comments fixed please review again

PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectscroll_progressgit

I'm a robot and this is an automated message from Project Applications Scraper.

keshavv’s picture

Status: Needs work » Needs review

Please review again.

keshavv’s picture

Issue summary: View changes
FileSize
62.33 KB
45.25 KB
56.85 KB
keshavv’s picture

Issue summary: View changes
keshavv’s picture

Issue summary: View changes
keshavv’s picture

Issue summary: View changes
FileSize
39.56 KB
39.86 KB
47.04 KB
joshi88’s picture

Assigned: Unassigned » joshi88
joshi88’s picture

I checked this module on both mode admin login and logout its working fine.

keshavv’s picture

Assigned: joshi88 » keshavv
keshavv’s picture

Assigned: keshavv » Unassigned
Satyam Upadhyay’s picture

Status: Needs review » Needs work
FileSize
85.16 KB

@keshav.k,

Fix your https://pareview.sh/node/2003 issue those are as follows:

Regards
Satyam

keshavv’s picture

Status: Needs work » Needs review

review again

keshavv’s picture

keshavv’s picture

Issue summary: View changes
keshavv’s picture

Status: Needs review » Reviewed & tested by the community
keshavv’s picture

Issue summary: View changes
keshavv’s picture

Issue summary: View changes
amit.drupal’s picture

That many if - else there would be better to replace by switch statement.

keshavv’s picture

Status: Reviewed & tested by the community » Closed (duplicate)

This project is abandoned and will see no further development.
Working on https://www.drupal.org/sandbox/amitdrupal/2883766

apaderno’s picture