We have to convert the module to short array as per new coding standard

CommentFileSizeAuthor
#3 jquery_colorpicker_array_search_results.png50.61 KBdhruveshdtripathi
#2 2881325-2.patch1.38 KBPavan B S
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S CreditAttribution: Pavan B S at Valuebound commented
Status: Active » Needs review
FileSize
2881325-2.patch1.38 KB

Applying the patch, please review

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda commented
Status: Needs review » Reviewed & tested by the community
FileSize
jquery_colorpicker_array_search_results.png50.61 KB

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually. As you can see in the attached png file, earlier there were 5 array declarations, after applying patch that is 1. That 1 array declarations are in_array.

Good work!

Jaypan’s picture

Jaypan CreditAttribution: Jaypan commented
Status: Reviewed & tested by the community » Closed (outdated)

Thanks for your work, unfortunately I converted the entire module to coder standards, including the array syntax, before I saw this thread, so the patch doesn't work anymore, and with nothing to push, there is nothing to credit you with. I do appreciate your efforts though.