The "core/drupal.dialog.ajax" library explicitly depends on "core/drupal.ajax" and "core/drupal.dialog" so it is unnecessary for this example to declare dependencies on these dependencies of "core/drupal.dialog.ajax".

Patch to follow.

CommentFileSizeAuthor
#2 2881278-modal-form-unnecessary-attachments.patch850 bytesjdleonard
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jdleonard created an issue. See original summary.

jdleonard’s picture

jdleonard
he/him
Primary language English
Location Austin
CreditAttribution: jdleonard commented
Status: Active » Needs review
FileSize
2881278-modal-form-unnecessary-attachments.patch850 bytes

  • Mile23 committed a40c64b on 8.x-1.x authored by jdleonard 
    Issue #2881278 by jdleonard: Unnecessary library attachments for Modal...
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs review » Fixed

Nice work, thanks.

I discovered this while manually testing: #2883725: fapi_example modal dialog does not show result message w/ JS

Committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.