We have to convert the module to short array as per new coding standard

CommentFileSizeAuthor
#3 views_block_filter_block_array_search_results.png58.55 KBdhruveshdtripathi
#2 2881016-2.patch7.59 KBPavan B S
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S CreditAttribution: Pavan B S at Valuebound commented
Status: Active » Needs review
FileSize
2881016-2.patch7.59 KB

Applying the patch, please review

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda commented
Status: Needs review » Reviewed & tested by the community
FileSize
views_block_filter_block_array_search_results.png58.55 KB

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually. As you can see in the attached png file, earlier there were 21 array declarations, after applying patch there are 0.

Good work!

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar as a volunteer and at QED42 commented
Assigned: Unassigned » yogeshmpawar

  • Yogesh Pawar committed 5057db3 on 8.x-1.x 
    Issue #2881016 by Pavan B S, dhruveshdtripathi, Yogesh Pawar: Convert...
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar as a volunteer and at QED42 commented
Assigned: yogeshmpawar » Unassigned
Status: Reviewed & tested by the community » Fixed

Committed & pushed to 8.x-1.x branch so marking this issue as fixed & also assigning credits.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.