Font Awesome Icons module needs to be converted to use short array syntax as per new coding standard.

CommentFileSizeAuthor
#4 update_adhere_coding_standards-2880698-3.patch12.68 KBDaniel.Moberly
#3 update_adhere_coding_standards-2880698-3.patch12.56 KBDaniel.Moberly
#2 short_array_syntax-2880698-2.patch7.36 KBMunavijayalakshmi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Munavijayalakshmi created an issue. See original summary.

Munavijayalakshmi’s picture

Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound commented
Assigned: Munavijayalakshmi » Unassigned
Status: Active » Needs review
FileSize
short_array_syntax-2880698-2.patch7.36 KB
Daniel.Moberly’s picture

Daniel.Moberly CreditAttribution: Daniel.Moberly commented
Title: Convert module to use short array syntax (new coding standard). » Update module to adhere to coding standards
FileSize
update_adhere_coding_standards-2880698-3.patch12.56 KB

This module actually does not adhere to many coding standards. I have updated the entire module to pass all coding standard tests, including the array() -> [] change. Attaching patch.

Daniel.Moberly’s picture

Daniel.Moberly CreditAttribution: Daniel.Moberly commented
FileSize
update_adhere_coding_standards-2880698-3.patch12.68 KB

Rerolling patch

  • Daniel.Moberly committed 1455ef3 on 8.x-1.x 
    Issue #2880698 by Daniel.Moberly: Update module to adhere to coding...
Daniel.Moberly’s picture

Daniel.Moberly CreditAttribution: Daniel.Moberly commented
Status: Needs review » Fixed

Released in 8.x-1.3

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.