Problem/Motivation

Create button group paragraph type based on Bootstrap framework button group component.
Bootstrap documentation: https://v4-alpha.getbootstrap.com/components/button-group/

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 button_group_paragraph-2880636-8.patch15.97 KBthenchev
#7 button_group_paragraph-2880636-7.patch22.33 KBnjagojevic
#7 interdiff-2880636-6-7.txt1.29 KBnjagojevic
#6 button_group_paragraph-2880636-6.patch22.33 KBnjagojevic
#6 interdiff-2880636-4-6.txt2.93 KBnjagojevic
#4 different-button-group.png7.63 KBnjagojevic
#4 button-group.png10.19 KBnjagojevic
#4 button_group_paragraph-2880636-4.patch22.68 KBnjagojevic
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

njagojevic created an issue. See original summary.

njagojevic’s picture

njagojevic CreditAttribution: njagojevic commented
Assigned: Unassigned » njagojevic

Working on it.

njagojevic’s picture

njagojevic CreditAttribution: njagojevic commented
Related issues: +#2875253: Buttons paragraph type
njagojevic’s picture

njagojevic CreditAttribution: njagojevic commented
Status: Active » Needs review
FileSize
button_group_paragraph-2880636-4.patch22.68 KB
button-group.png10.19 KB
different-button-group.png7.63 KB

Added button group paragraph type. First should be #2875253: Buttons paragraph type commited.

Button group with same style applied on each button:
button group

Button group with different styles applied on buttons:
different button group

CTaPByK’s picture

CTaPByK CreditAttribution: CTaPByK commented
Status: Needs review » Needs work

I can't apply this patch, i got error:

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "accordion" plugin does not exist. in Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (line 52 of core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php).

  1. +++ b/config/install/paragraphs.paragraphs_type.pcb_button.yml
@@ -0,0 +1,29 @@
+  accordion:
+    paragraph_accordion_field: ''

    I guess you have some demo installed. 

  2. +++ b/paragraphs_collection_bootstrap.module
@@ -0,0 +1,96 @@
+    $behaviorSettings = $variables['paragraph']->getAllBehaviorSettings();
...
+    if (isset($behaviorSettings['style'])) {
+      switch ($behaviorSettings['style']['style']) {

    Be consistent; do not mix camelCase and snake_case variable naming inside a file.
    https://www.drupal.org/docs/develop/standards/coding-standards#naming
    Please check Code Sniffer setting inside your IDE.

njagojevic’s picture

njagojevic CreditAttribution: njagojevic commented
Status: Needs work » Needs review
FileSize
interdiff-2880636-4-6.txt2.93 KB
button_group_paragraph-2880636-6.patch22.33 KB

Removed nonexistent plugins from config files and fixed coding standards.

njagojevic’s picture

njagojevic CreditAttribution: njagojevic commented
FileSize
interdiff-2880636-6-7.txt1.29 KB
button_group_paragraph-2880636-7.patch22.33 KB

Changed label and description.

thenchev’s picture

thenchev CreditAttribution: thenchev commented
Assigned: njagojevic » thenchev
FileSize
button_group_paragraph-2880636-8.patch15.97 KB

  • njagojevic authored a5682e6 on 8.x-1.x 
    Issue #2880636 by njagojevic, Denchev, CTaPByK: Button group paragraph...
thenchev’s picture

thenchev CreditAttribution: thenchev commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.