This issue will focus on backporting the node access code from the D8 version of the module.

Even though the node access layer is far from perfect, trying to work around it in Group 7 was a bad idea in hindsight. It disallowed Group 7 to work well with other node access modules and introduced a system which was hard for others to understand. I will remove this in favor of core's node access system.

The node access code is thoroughly tested by PHPUnit in Group 8, so backporting it (almost) 1:1 should come without too many bugs.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kristiaanvandeneynde created an issue. See original summary.

kristiaanvandeneynde’s picture

Status: Active » Needs review
FileSize
51.4 KB
kristiaanvandeneynde’s picture

FileSize
9.3 KB
57.78 KB

Fixed a few bugs that slipped into the last patch.

P.S.: It's worth noting that by backporting the Group 8 functionality, we also introduce a permission to view unpublished nodes in a group.

kristiaanvandeneynde’s picture

Status: Needs review » Fixed

Committing as the existing tests all went green both in D7 and D8.

P2790’s picture

When doing drush dbup I get the following error:
Error: syntax error, unexpected '[' in /sites/all/modules/group/modules/gnode/gnode.node_access.inc, line 159
Didn't think it was worth posting a new issue

P2790’s picture

Deleting comment

P2790’s picture

Sorry ignore my previous comment.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.