Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This issue will focus on backporting the node access code from the D8 version of the module.
Even though the node access layer is far from perfect, trying to work around it in Group 7 was a bad idea in hindsight. It disallowed Group 7 to work well with other node access modules and introduced a system which was hard for others to understand. I will remove this in favor of core's node access system.
The node access code is thoroughly tested by PHPUnit in Group 8, so backporting it (almost) 1:1 should come without too many bugs.
Comment | File | Size | Author |
---|---|---|---|
#3 | group-2880603-3.patch | 57.78 KB | kristiaanvandeneynde |
#3 | interdiff-2-3.txt | 9.3 KB | kristiaanvandeneynde |
Comments
Comment #2
kristiaanvandeneyndeComment #3
kristiaanvandeneyndeFixed a few bugs that slipped into the last patch.
P.S.: It's worth noting that by backporting the Group 8 functionality, we also introduce a permission to view unpublished nodes in a group.
Comment #5
kristiaanvandeneyndeCommitting as the existing tests all went green both in D7 and D8.
Comment #6
P2790 CreditAttribution: P2790 commentedWhen doing drush dbup I get the following error:
Error: syntax error, unexpected '[' in /sites/all/modules/group/modules/gnode/gnode.node_access.inc, line 159
Didn't think it was worth posting a new issue
Comment #7
P2790 CreditAttribution: P2790 commentedDeleting comment
Comment #8
P2790 CreditAttribution: P2790 commentedSorry ignore my previous comment.