Disqus module needs to be converted to use short array syntax as per new coding standard.

CommentFileSizeAuthor
#2 short_array_syntax-2880365-2.patch24.09 KBMunavijayalakshmi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Munavijayalakshmi created an issue. See original summary.

Munavijayalakshmi’s picture

Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound commented
Assigned: Munavijayalakshmi » Unassigned
Status: Active » Needs review
FileSize
short_array_syntax-2880365-2.patch24.09 KB
Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews commented

The patch in #2 applied cleanly to the latest disqus 8.x-1.x-dev, but still needs to be reviewed.

Applied patch README.md cleanly.
Applied patch disqus.module cleanly.
Applied patch src/Element/Disqus.php cleanly.
Applied patch src/Form/DisqusSettingsForm.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/DisqusFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldWidget/DisqusWidget.php cleanly.
Applied patch src/Plugin/migrate/destination/DisqusComment.php cleanly.
Applied patch src/Plugin/migrate/source/DisqusComment.php cleanly.
Applied patch src/Plugin/views/field/DisqusCommentCount.php cleanly.
gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at Axelerant for Drupal India Association commented

Fixed all the issues shown by PHPCS as part of this issue only.

  • Munavijayalakshmi authored e26e394 on 8.x-1.x 
    Issue #2880365 by Munavijayalakshmi, cityofoaksdesign@gmail.com, gaurav....
gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at Axelerant for Drupal India Association commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.