[D7] Exit Bee

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectexitbeegit

I'm a robot and this is an automated message from Project Applications Scraper.

Hi exitbee,

// Build exitbee tracking code.
    $script = '(function(doc) {
          var xtb = document.createElement("script");
          xtb.type = "text/javascript";
          xtb.async = true;
          xtb.src = window.location.protocol + "//' . EXITBEE_BASE_URL . '/c/' . $website_key . '/exitbee.js";
          document.getElementsByTagName("head")[0].appendChild(xtb);
      }())';

    drupal_add_js($script, array(
      'scope' => 'footer',
      'type' => 'inline',
      'requires_jquery' => FALSE,
    ));

EXITBEE_BASE_URL & $website_key can be passed to Javascript via Drupal Settings. And Javascript can be moved to separate ".js" file and include the file on page.

Else the code looks good.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

Review of the 7.x-1.x branch (commit dac8890):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: .../site1101/web/vendor/drupal/pareviewsh/pareview_temp/exitbee.install
  --------------------------------------------------------------------------
  FOUND 2 ERRORS AFFECTING 2 LINES
  --------------------------------------------------------------------------
   24 | ERROR | Variable "UUID" starts with a capital letter, but only
      |       | $lowerCamelCase or $snake_case is allowed
   25 | ERROR | Variable "UUID" starts with a capital letter, but only
      |       | $lowerCamelCase or $snake_case is allowed
  --------------------------------------------------------------------------
  
  Time: 585ms; Memory: 4Mb
  

• ESLint has found some issues with your code (please check the JavaScript coding standards).
  

  /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/eb.js: line 1, col 2, Error - Use the function form of 'use strict'. (strict)
  /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/eb.js: line 1, col 10, Error - Missing space before function parentheses. (space-before-function-paren)
  /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/eb.js: line 2, col 36, Error - Strings must use singlequote. (quotes)
  /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/eb.js: line 3, col 14, Error - Strings must use singlequote. (quotes)
  /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/eb.js: line 5, col 40, Error - Strings must use singlequote. (quotes)
  /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/eb.js: line 5, col 85, Error - Strings must use singlequote. (quotes)
  /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/eb.js: line 5, col 134, Error - Strings must use singlequote. (quotes)
  /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/eb.js: line 6, col 33, Error - Strings must use singlequote. (quotes)
  /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/eb.js: line 7, col 6, Error - Newline required at end of file but not found. (eol-last)
  
  9 problems
  

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account

No: Does not follow the guidelines for individual user accounts. No individual user

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements

Coding style & Drupal API usage

1. (*) Variable "UUID" starts with a capital letter in exitbee.install
2. (*) JavaScript coding standards in eb.js

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.