Problem/Motivation

Add a source status "ERROR", for when an upload/update fails from the TMS side.

Proposed resolution

Add the source status "ERROR" and mark it visually.

Remaining tasks

Tests+patch

User interface changes

When an upload/update fails, we mark with the error status. Visually this would be red in the bulk management page, and clicking on it retries the upload/update.

API changes

None

Data model changes

None

CommentFileSizeAuthor
#13 2879896-source-status-error-13.only-tests.patch60.69 KBpenyaskito
#13 2879896-source-status-error-13.patch78.34 KBpenyaskito
#13 2879896-source-status-error-11-13.interdiff.txt23.47 KBpenyaskito
#2 2879896-source-status-error-2.patch14.4 KBpenyaskito
#2 2879896-source-status-error-2.only-tests.patch8.47 KBpenyaskito
#4 2879896-source-status-error-2-4.interdiff.txt14.52 KBpenyaskito
#4 2879896-source-status-error-4.only-tests.patch16.51 KBpenyaskito
#4 2879896-source-status-error-4.patch25.33 KBpenyaskito
#6 2879896-source-status-error-4-6.interdiff.txt23.38 KBpenyaskito
#6 2879896-source-status-error-6.only-tests.patch30 KBpenyaskito
#6 2879896-source-status-error-6.patch47.2 KBpenyaskito
#9 2879896-source-status-error-6-9.interdiff.txt773 bytespenyaskito
#9 2879896-source-status-error-9.only-tests.patch30 KBpenyaskito
#9 2879896-source-status-error-9.patch47.19 KBpenyaskito
#11 2879896-source-status-error-9-11.interdiff.txt11.45 KBpenyaskito
#11 2879896-source-status-error-11.only-tests.patch40.74 KBpenyaskito
#11 2879896-source-status-error-11.patch57.93 KBpenyaskito
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Active » Needs review
FileSize
2879896-source-status-error-2.patch14.4 KB
2879896-source-status-error-2.only-tests.patch8.47 KB

Added for content with tests for the different ways of uploading. We need similar tests for updating.

Status: Needs review » Needs work

The last submitted patch, 2: 2879896-source-status-error-2.only-tests.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Needs work » Needs review
FileSize
2879896-source-status-error-2-4.interdiff.txt14.52 KB
2879896-source-status-error-4.only-tests.patch16.51 KB
2879896-source-status-error-4.patch25.33 KB

Tests for updating.

The last submitted patch, 4: 2879896-source-status-error-4.only-tests.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
FileSize
2879896-source-status-error-4-6.interdiff.txt23.38 KB
2879896-source-status-error-6.only-tests.patch30 KB
2879896-source-status-error-6.patch47.2 KB

Added tests for config entities. Still we lack testing coverage for fields and config objects.

The last submitted patch, 6: 2879896-source-status-error-6.only-tests.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 6: 2879896-source-status-error-6.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Needs work » Needs review
FileSize
2879896-source-status-error-6-9.interdiff.txt773 bytes
2879896-source-status-error-9.only-tests.patch30 KB
2879896-source-status-error-9.patch47.19 KB

Fixed tests.

The last submitted patch, 9: 2879896-source-status-error-9.only-tests.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
FileSize
2879896-source-status-error-11.patch57.93 KB
2879896-source-status-error-11.only-tests.patch40.74 KB
2879896-source-status-error-9-11.interdiff.txt11.45 KB

Added tests for fields. We lack testing coverage for config objects only.

The last submitted patch, 11: 2879896-source-status-error-11.only-tests.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
FileSize
2879896-source-status-error-11-13.interdiff.txt23.47 KB
2879896-source-status-error-13.patch78.34 KB
2879896-source-status-error-13.only-tests.patch60.69 KB

And added testing coverage for config objects.

Status: Needs review » Needs work

The last submitted patch, 13: 2879896-source-status-error-13.only-tests.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Needs work » Reviewed & tested by the community

Tests passed and failed as expected ^_^

  • penyaskito committed 41ccfeb on 8.x-1.x 
    Issue #2879896 by penyaskito: Add error as a source status, in case an...
  • penyaskito committed b092707 on 8.x-2.x
    Issue #2879896 by penyaskito: Add error as a source status, in case an...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Reviewed & tested by the community » Fixed

Committed 41ccfeb and pushed to 8.x-1.x. Thanks!
Cherry picked b092707 and pushed to 8.x-2.x!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.