Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
#2831274: Bring Media entity module to core as Media module didn't add an entry to MAINTAINERS.txt for the media system/module. Also given @slashrsm's wish to take some time away from Drupal (https://janezurevc.name/time-take-some-time-drupal-community) we should respect that and discuss maintainership of the initiative too.
@seanB accepted of subsystem maintainer responsibilities in #14.
@phenaproxima accepted subsystem maintainer responsibilities in #15.
Proposed resolution
Add seanB and phenaproxima as subsystem maintainers for media.
Remaining tasks
User interface changes
None
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#18 | 2879757-18.patch | 574 bytes | phenaproxima |
#6 | 2879757.patch | 580 bytes | naveenvalecha |
#5 | 2879757.patch | 0 bytes | naveenvalecha |
|
Comments
Comment #2
seanBI would be open to add my name to the list, but I would definitely need help.
Comment #3
phenaproximaI would like my name on the list.
Comment #4
chr.fritschI could not imagine anyone else. @seanB and @phenaproxima are very passionated and two long term supporters of the media initiative.
Comment #5
naveenvalechaRTBC +1 with patch.
Sean and Adam both are very long term contributor to the media intiative.
I think as per Drupal governance for new maintainers which will be added to Maintainers.txt requires Dries approval. As phenaproxima is already a maintainer of Migrate System so committers can add him, for SeanB it requires explicit permissions from Dries
Keeping the issue with the same status. Pinged @xjm to confirm that the issue is in the right status.
//Naveen
Comment #6
naveenvalechaComment #9
phenaproximaThe patch looks good. Ready for review from @xjm and @Dries.
Comment #10
yoroy CreditAttribution: yoroy at Roy Scholten commentedrtbc if you want to trigger the committers :)
Comment #11
cilefen CreditAttribution: cilefen commentedHi! The patch adds module maintainers but doesn't do anything on the initiative section as mentioned in the summary.
Comment #12
cilefen CreditAttribution: cilefen commentedJust for completeness: https://www.drupal.org/contribute/core/maintainers#maintainer-types
If you want to make this issue just about the new module and push the initiative question to another issue, I suppose that would work.
Comment #13
xjmSo to clarify, initiative coordinator and module maintainer are different responsibilities:
https://www.drupal.org/contribute/core/maintainers#initiative
versus
https://www.drupal.org/contribute/core/maintainers#subsystem
If the contributors are just stepping up for maintainership of the subsystem, that's awesome. :) Let's just update the summary confirming that both @phenaproxima and @seanB are up for the subsystem maintainer responsibilities linked above, then any committer can commit it.
If you would like to help out as initiative coordinators, then that's a different patch that we can also review with Dries.
Thanks @seanB and @phenaproxima for stepping up for this!
Comment #14
seanBConfirming that I accept subsystem maintainer responsibilities. I also confirm that I want to help out as a Initiative coordinator, but it would be best if phenaproxima could join there as well.
Comment #15
phenaproximaI also confirm that I accept subsystem maintainer responsibilities for Media.
I would like to help with initiative coordination, but I think I might be too disorganized for that. I would rather discuss that with other Media folk in IRC before accepting those responsibilities, so this patch is only for the subsystem.
Comment #16
phenaproximaI think we're good here. Back to RTBC!
Comment #17
cilefen CreditAttribution: cilefen commentedComment #18
phenaproximaAlphabetized the names as requested on IRC by @cilefen.
Comment #21
cilefen CreditAttribution: cilefen commentedCommitted 7c56948 and pushed to 8.4.x. Thank you so much for stepping up on this important effort in Drupal core!
P.S. I opened #2883921: Place migrate sections in alphabetical order in MAINTAINERS.txt
Comment #22
cilefen CreditAttribution: cilefen commented@xjm was nice enough to remind me so: @phenaproxima and @seanB have been given appropriate permissions on https://www.drupal.org/node/3060 and https://groups.drupal.org/core.
Comment #23
xjmBy the way, @seanB also expressed interest in helping as an initiative lead as well. We can file a separate issue for that since @phenaproxima indicated he wants to discuss the role first. We can also use that new issue to reach out to contributors and see if anyone else can help support @seanB for those efforts. :)
Edit: misremembered comment. Fixed.
Comment #24
seanBAdded #2884700: Initiative lead for Media Initiative to discuss the Initiative Lead for Media.