Problem/Motivation

Token hides the menu_link field by default for entity view and form displays, but is using a deprecated key to do this.

Source: http://cgit.drupalcode.org/drupal/tree/core/lib/Drupal/Core/Entity/Entit...

Proposed resolution

Use the hidden region instead of the hidden type.

Remaining tasks

Review the patch.

User interface changes

None.

API changes

None.

Data model changes

None.

Comments

samuel.mortenson created an issue. See original summary.

samuel.mortenson’s picture

Status: Needs review » Needs work

This should work, but I see that the region is still defaulting to content.

samuel.mortenson’s picture

Status: Needs work » Needs review

Nevermind, I think this is working!

Berdir’s picture

Thanks, is there an easy way to test this?

samuel.mortenson’s picture

Hm, I'm not sure about the best way, but an easy way is to confirm that the "Menu Link" field is hidden on all the Entity form/view displays it's attached to.

Berdir’s picture

Status: Needs review » Needs work

I was thinking that this would be an API change if it's deprecated.

But that's not the point, the whole thing is bogus. If it shouldn't be shown then we shouldn't define display options in the first place. Just remove all of that and it should be fine.

Then we also don't need test coverage IMHO :)