I've patched redhen_connection so that related entities can be used in views with their available field data.

CommentFileSizeAuthor
#13 redhen_connection-add_support_for_views_relationships-2879091-13.patch4.91 KBgcb
#2 redhen_connection-add_support_for_views_relationships-2879091-2.patch15.38 KBarosboro
#4 redhen_connection-add_support_for_views_relationships-updated.patch15.48 KBarosboro
#6 redhen_connection-add_support_for_views_relationships-2879091-6.patch6.07 KBarosboro
#9 redhen_connection-add_support_for_views_relationships-2879091-8.patch15.14 KBarosboro
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

arosboro created an issue. See original summary.

arosboro’s picture

arosboro CreditAttribution: arosboro at DropForge Labs commented
FileSize
redhen_connection-add_support_for_views_relationships-2879091-2.patch15.38 KB
arosboro’s picture

arosboro CreditAttribution: arosboro at DropForge Labs commented

See github PR #86 https://github.com/thinkshout/redhen/pull/86

arosboro’s picture

arosboro CreditAttribution: arosboro at DropForge Labs commented
FileSize
redhen_connection-add_support_for_views_relationships-updated.patch15.48 KB

I've updated the patch to make relationships for entity_type, endpoint id, connection type so if one entity type is used in more than one connection type, the appropriate relationship can be brought in.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford at OpenConcept Consulting Inc. commented

Thanks! Sounds like a powerful addition.

arosboro’s picture

arosboro CreditAttribution: arosboro at DropForge Labs commented
FileSize
redhen_connection-add_support_for_views_relationships-2879091-6.patch6.07 KB

I've updated the patch to apply cleanly to the latest 8.x-1.x branch.

gcb’s picture

gcb
he/him
CreditAttribution: gcb at ThinkShout commented
Assigned: Unassigned » gcb

Yep! Thanks for this. I'll put it on my plate and try to get reviewed soon.

arosboro’s picture

arosboro CreditAttribution: arosboro at DropForge Labs commented
Status: Needs review » Needs work

The attached patch in #6 does not bring along newly created files. I will update once I have a passing build with a re-rolled patch.

arosboro’s picture

arosboro CreditAttribution: arosboro at DropForge Labs commented
Status: Needs work » Needs review
FileSize
redhen_connection-add_support_for_views_relationships-2879091-8.patch15.14 KB

This patch has been reviewed and should help demonstrate the functionality that is added.

  • gcb committed 460b785 on 8.x-1.x authored by arosboro 
    Issue #2879091 by arosboro: redhen_connection Support for views...
gcb’s picture

gcb
he/him
CreditAttribution: gcb at ThinkShout commented
Status: Needs review » Fixed

This is great, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

gcb’s picture

gcb
he/him
CreditAttribution: gcb at ThinkShout commented
Status: Closed (fixed) » Needs work
FileSize
redhen_connection-add_support_for_views_relationships-2879091-13.patch4.91 KB

In revisiting this, I've found a couple of needs/challenges, so re-opening.

A. @arosboro, I missed this in your original patch, but you have this code referencing a plugin, but the plugin doesn't exist:

'filter' => [
  'handler' => '\Drupal\redhen_connection\Plugin\views\HandlerFilterStatus'
],

Do you have this plugin written somewhere and it just didn't make it into the patch?

B. I found the need to get to the connection entity itself, and realize there are really 3 plugins needed:

  1. Across the Connection, from Endpoint to Endpoint (what the original patch does
  2. From an Endpoint to the Connection entity itself
  3. From a Connection Entity to an Endpoint

I can imagine that the first one is actually not needed, as the other two can create the same effect. However, I think it makes sense to have them.

Here's a patch starting the work to create these. One element I'd like to add is filtering the types of content that each connection asks for: currently they let you attach them to any entity type, even though our configuration makes it clear what content type should be allowed. What I have feels confusing and sloppy at this point, although it seems to work.

arosboro’s picture

arosboro CreditAttribution: arosboro commented

Hi, @gcb, I have shifted my focus, and no longer participate actively in the drupal community. You may be able to get support with this partially complete work, from @chertzog (Chris Hertzog). I believe he is still supporting a codebase that uses these patches.

Wishing you the best.

gcb’s picture

gcb
he/him
CreditAttribution: gcb at ThinkShout commented
Component: redhen_relation » Shared
Status: Needs work » Closed (duplicate)

This functionality has been added separately.